From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#34852: 26.1; seq-intersection ignores nil as element Date: Thu, 14 Mar 2019 17:08:55 +0000 Message-ID: <87k1h1criw.fsf@tcd.ie> References: <87zhpxabn3.fsf@tcd.ie> <87va0lmwlg.fsf@web.de> <87d0mtpfqb.fsf@petton.fr> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="203094"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Michael Heerdegen , "Miguel V. S. Frasson" , 34852@debbugs.gnu.org, Stefan Monnier To: Nicolas Petton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 14 18:17:00 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h4TyV-000qj4-RF for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Mar 2019 18:16:59 +0100 Original-Received: from localhost ([127.0.0.1]:42062 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4TyU-0004CN-Lh for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Mar 2019 13:16:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4Trn-0006JF-Km for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 13:10:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4Trm-0007xd-Lr for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 13:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58660) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4Trm-0007xW-FA for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 13:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h4Trm-0004C1-7P for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 13:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2019 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34852 X-GNU-PR-Package: emacs Original-Received: via spool by 34852-submit@debbugs.gnu.org id=B34852.155258334516030 (code B ref 34852); Thu, 14 Mar 2019 17:10:02 +0000 Original-Received: (at 34852) by debbugs.gnu.org; 14 Mar 2019 17:09:05 +0000 Original-Received: from localhost ([127.0.0.1]:43964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4Tqq-0004AU-Qn for submit@debbugs.gnu.org; Thu, 14 Mar 2019 13:09:05 -0400 Original-Received: from mail-ed1-f45.google.com ([209.85.208.45]:37314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4Tqo-00049v-H9 for 34852@debbugs.gnu.org; Thu, 14 Mar 2019 13:09:03 -0400 Original-Received: by mail-ed1-f45.google.com with SMTP id m12so5288014edv.4 for <34852@debbugs.gnu.org>; Thu, 14 Mar 2019 10:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7TCYwgDIdrrN4iU2xauXuCbGxxn4MulbcUpbIg+pl6o=; b=ycZpToRGP4zx5rRXm03FBKHIdcr/ub6mtR1fTRbVuTDU6+Od21lUY33kmwR0nYO4R9 Qso8QKc6lm95IE2k4L6MQwEndA8voZoLz1r9Aaxp+SBZiNiqKlrjXsZIV37FZFrWG4Yc FzhFxl5HqYlpYjZ0yFJn6qDBBaCraThMwLwK77Twu11D/W7gsrOI4c25qbAVXeWClDn1 XESGM1bU51R+h6KwQlMIClaf9+KvfHOAs7PE9vCBmwAA3GcaBwHGd/g7+Sb0i7n0wm/J lqfPd1aRJuYh1Y0wpzHWu0J8gGlftEHiYqsa9qTTXdhTI9lEQr+IRkyLFJUjXFvUg/H+ W7Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7TCYwgDIdrrN4iU2xauXuCbGxxn4MulbcUpbIg+pl6o=; b=I6Fjk0KcSp2X1OagFuiU41ldnS9h8HCUlgdIuHoZ5796SANGKL4dfj7MU+3PMhJr4g IZS8ZTMLdq82Nm5PnQk5RCIK5+6GHZDz6qLRvOoqiDypuTLcE2VVgO4mFtlsQ502w/wV 6DKaKTD6LHSliOH2+UczozIOQwswTe6dET7DfJUkzNEM+yTlKKMYhmQcJDJtJGgKvRQ1 OgmhKn3BK2h7ceVYgEWmxkgSudsxQh4ZedU8ze0GIWFLhXXsw5xAUiayo+PK0v8QZesJ 4lNio2egGycfw7+AZCh3SlAeF+24jCptJ7Ght3ctiUr2DHhLyswLIEkPzg2dRG1m3N+L 4ESg== X-Gm-Message-State: APjAAAU3GqQGMz1U3PtXcvxyQu8zU8NdjzTw7S9Bs10xRJJTMzpZT9eM 0iFLcEnNHqPDDASpbMmojo0uFg== X-Google-Smtp-Source: APXvYqyxVvCTx7ZI51Fw2qGjj6APw/ShP4uMwflwmZL4kc3M2KuUPk8+WSUa+XUVTUOKiUW+nl4FBA== X-Received: by 2002:a50:f411:: with SMTP id r17mr2179812edm.262.1552583336777; Thu, 14 Mar 2019 10:08:56 -0700 (PDT) Original-Received: from localhost ([134.226.214.253]) by smtp.gmail.com with ESMTPSA id b22sm1672392edb.5.2019.03.14.10.08.55 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 14 Mar 2019 10:08:56 -0700 (PDT) In-Reply-To: <87d0mtpfqb.fsf@petton.fr> (Nicolas Petton's message of "Thu, 14 Mar 2019 17:45:16 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156348 Archived-At: Nicolas Petton writes: > Michael Heerdegen writes: > > Hi Michael, > >> We also have `seq-some' which can be used as a contain predicate, >> e.g. to fix this bug: > > Using seq-contains was wrong, and I think seq-some should have been used > instead, so I like your patch better (it's IMO better to use seq-some > used as a predicate than seq-position). > > Unless somebody disagrees, I'll install your patch. If you go with the seq-some patch then please edit it to avoid using apply-partially, which is quite inefficient. The implementations of seq-set-equal-p, seq-uniq, and seq-difference will also need to be updated, in addition to that of seq-intersection. -- Basil