all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* org-notmuch: Improved tree support
@ 2019-03-19 10:07 Pierre Neidhardt
  2019-04-03 10:56 ` Nicolas Goaziou
  0 siblings, 1 reply; 5+ messages in thread
From: Pierre Neidhardt @ 2019-03-19 10:07 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

Hi,

1. `org-notmuch-store-link' does not allow to store links to email at
point in tree view.  Easy fix:

--8<---------------cut here---------------start------------->8---
(defun org-notmuch-store-link ()
  "Store a link to a notmuch search or message."
-  (when (eq major-mode 'notmuch-show-mode)
+  (when (or (eq major-mode 'notmuch-show-mode)
+            (eq major-mode 'notmuch-tree-mode))
    (let* ((message-id (notmuch-show-get-message-id t))
--8<---------------cut here---------------end--------------->8---

2. A while back
https://lists.gnu.org/archive/html/emacs-orgmode/2014-07/msg00380.html
was merged.  I think using a defcustom here is not very intuitive for
people who use both the tree view and the thread view.  I would expect
the following:

- Opening a tree link will open the tree view.
- Opening a search link will open the search view.

It's easy to implement:

- Deprecate the former defcustom.
- Copy/paste the org-notmuch-search* code to org-notmuch-tree*.

Thoughts?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-04-10 13:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-19 10:07 org-notmuch: Improved tree support Pierre Neidhardt
2019-04-03 10:56 ` Nicolas Goaziou
2019-04-09 17:23   ` Pierre Neidhardt
2019-04-10 13:19     ` Nicolas Goaziou
2019-04-10 13:27       ` Pierre Neidhardt

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.