From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#35121: [debbugs.el] debbugs-make-control-message doesn't always ask for version Date: Wed, 03 Apr 2019 21:48:17 +0200 Message-ID: <87k1gakgzi.fsf@gmx.de> References: <87h8bffco1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="71875"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35121@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 03 21:49:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBlsp-000IWW-FQ for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Apr 2019 21:49:15 +0200 Original-Received: from localhost ([127.0.0.1]:53976 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBlso-00026f-2D for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Apr 2019 15:49:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBlse-00025I-HR for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 15:49:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBlsd-0003PT-98 for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 15:49:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57934) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBlsc-0003P4-TW for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 15:49:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hBlsc-0007sH-Ih for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 15:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Apr 2019 19:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35121 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35121-submit@debbugs.gnu.org id=B35121.155432090830231 (code B ref 35121); Wed, 03 Apr 2019 19:49:02 +0000 Original-Received: (at 35121) by debbugs.gnu.org; 3 Apr 2019 19:48:28 +0000 Original-Received: from localhost ([127.0.0.1]:43245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBls4-0007rV-Fv for submit@debbugs.gnu.org; Wed, 03 Apr 2019 15:48:28 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:53865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBls1-0007rI-Ey for 35121@debbugs.gnu.org; Wed, 03 Apr 2019 15:48:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1554320898; bh=zGQZgDhDGFG4xYzhpf0rsWpnN6Rpi9lLgXkbMyKvnr8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=AywEoIXy2IYIpTo41gaBhuViexZwox2vvr/C1Yyealk73YCj3wtTcSMQZ0hk3H32q ykVOJkykLlGoREalZSmy3OxEEd9faE5Fc+6105ii4a/KjoUuazJ2RJZGNcRPC5cGDZ w6vxxCD6BUw5gyb/WIoiP8u4+dl/fVUnPNJ/E9cc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([213.220.156.208]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MPlsg-1hGjgW1vsY-0052QL; Wed, 03 Apr 2019 21:48:18 +0200 In-Reply-To: <87h8bffco1.fsf@gmail.com> (Noam Postavsky's message of "Wed, 03 Apr 2019 09:20:30 -0400") X-Provags-ID: V03:K1:UohOBOOallOby3RCEiMDl3q8JgHYXfrMBvzNp7iDuXvAIAEWlqP QKsr3nfhA40I2Bjrlj9njnG9D5b1nSPHFhxlgQAWiyR8adr9pbYMRnzZaKFOecqsBPmymX0 iDlsT2OxHohgsZ2XXUrzO8GRERs25B4qyfuWnwQF+m27XralQBZIwz+0lmeXedlDHpN94vt h2B/+iZMfQGqIL71Ej5Tw== X-UI-Out-Filterresults: notjunk:1;V03:K0:MT3poCeTwJw=:+X4W2Tc30PPMGzKEGDdcVn R4oO+RB+9hiooQhQk5imtlgOjm+KlhcmXI4SjIj3uZObroaL+QtIva6d6jX/WnFTz/4eGzwxd +X5LdRCqZe482reWQw119myN8sxVcklymoJSRRYC89u2yTEfyjgBbuAkHzieSzgzmRmlksPz+ 22WngevajNKLRDRO/zIwCXm2iaNo6V4P8pof8lXOrbYxaL5DEUAizJVazs7/vmf+954CMSl6C rpi7nFmCve9LXBu1IYoAd8XImclxW7laqNbPiuLdCJKUXEsLsFHCvJxKGwtOoyeER6n0KOH/f 1WQReT1ZC/71162rpBgLBybUZqYvjzSfPIEAgpAcyAqObfjrD9pMSVzwhZ02LIbzJDaKV+iZx jdLK6k4d5opWIRSBVF3ERs7y1BCin61uUnWPXCcR60SshhUuubAWMPMtaZJzWqFWlTOlZCm1n SiESlE7eAYW6OqxmQV19uMV9kH+jaDPj/FvgxcxezuCfkX96qgiKUqRSUslR2E/KmI/zMNxx2 RfVVfLmVJefw3P/bWa1/CPkOHrC0nM5yI8ZRc/lSs4/+p86K04TDeub/xpWu0JjwULH+vg+2r BwJwPg9njCHlt24CoySja0FYRN+eX25xjN3NYxJE1/PF47wYli/IUFKmNyTWV1FY5DOoKVETc BUz5owSDywhKuKRrxv6SPfTkgGvHop5jkelndIs4YKA5/1tSTr6NU6/zCVGdqoQ3syQIFb4f2 tFbQYup1V53mzPCIIZPbKK8Lmj2MUkzTcGuNZief0qVL6l/nfFBJpsmLzf/uGd1Qg3DLgugP X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157132 Archived-At: Noam Postavsky writes: Hi Noam, > When using debbugs-make-control-message to make a "done" or "fixed" > control message from a message-mode buffer, it doesn't ask for for a > version number. That's because (debbugs-gnu-current-status) returns nil > outside the *Bugs* buffer, so the (member "emacs" (cdr (assq 'package > status))) check always fails. > > I think it should be okay to fallback to cache, or debbugs-get-status if > the cache is empty, right? Yes. Your patch LGTM. > By the way, I wonder if we should ask for version even if the package is > not Emacs (obviously the initial-input suggestion only works for Emacs), > surely other packages have versions too? I would suppose so. But in order to get feedback, you might ask on the ML. People using debbugs.el for other projects but Emacs are lurking there. Best regards, Michael.