From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Gramiak Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Renaming non-X x_* identifiers Date: Tue, 16 Apr 2019 10:24:13 -0600 Message-ID: <87k1ftdiky.fsf@gmail.com> References: <87wokp4okn.fsf@gmail.com> <87d0men4jx.fsf@gmail.com> <83o95sisk7.fsf@gnu.org> <87mulcnui4.fsf@gmail.com> <83bm1si7lf.fsf@gnu.org> <87ef6ont03.fsf@gmail.com> <83a7hci44l.fsf@gnu.org> <87a7hcndtc.fsf@gmail.com> <831s2nhza8.fsf@gnu.org> <87d0lpvq6n.fsf_-_@gmail.com> <83r2a5keo7.fsf@gnu.org> <87pnppu4ox.fsf@gmail.com> <83muktk9xb.fsf@gnu.org> <875zrhtg2i.fsf@gmail.com> <83ftqkk7lr.fsf@gnu.org> <877ebwvatg.fsf@gmail.com> <83y34cin3g.fsf@gnu.org> <87y34ctrs1.fsf@gmail.com> <83h8azianr.fsf@gnu.org> <87r2a3jh5h.fsf@gmail.com> <83y34bgldk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="173676"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: alan@idiocy.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 16 18:25:16 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGQtW-000izo-IX for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 18:25:14 +0200 Original-Received: from localhost ([127.0.0.1]:39357 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGQtV-0005Q7-K0 for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 12:25:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGQsa-0005ON-W5 for emacs-devel@gnu.org; Tue, 16 Apr 2019 12:24:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGQsa-00050G-7M for emacs-devel@gnu.org; Tue, 16 Apr 2019 12:24:16 -0400 Original-Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:35312) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGQsZ-0004z4-Vt; Tue, 16 Apr 2019 12:24:16 -0400 Original-Received: by mail-pf1-x444.google.com with SMTP id t21so10664868pfh.2; Tue, 16 Apr 2019 09:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=b5kdwGczhZD1AQnUxU9Rk10VvwNw3tpsti3IoFOg49s=; b=ePpoK7B8n3NCrFpqslL+g9kiURtuto0oc3NBzOmYXMk1upquCrYZ7sXmx/WeAQCa7v kCRd7WAKX3ps2og1ki+7rkn5fEL4KGR2I3mlTYIIX3eyhA7JmquBouTwuKpucjKuSNvA x9od0LNA/XftJaVnifCceQ216an/L8khBZrMm3zaJn+P5oCdsAVkBBpg21JUVV+GnTNU 2sT4yJgpQib7JXM7nU4olXukG8aMSOHtiKTwu2P1D8ydPCMAcVibkgEZSG76rPR/lqTO FS0d94S32fQwlNW6kB3a6i2B/DyE6zvhRog4QLO4l419XrT5E12fUlzxKkzn8GbG1Hkt tNxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=b5kdwGczhZD1AQnUxU9Rk10VvwNw3tpsti3IoFOg49s=; b=P0CNG3etLsPeIKSkOmMHUJwxut52lQ641yLla76wZsVzOyJHP+T68SVVfkQzi+4E4/ DLNP4vligfABQM2aGoP8vuWW6nPfBPRNvuFeW6HI2UjrLoVtl8xRoj7gJxOLnKEtm1fA Gdi2lU6a0vh0GJgDqKgR6ZQpF8yjUXC7EvxRp8Poimtcb/7BNpW2D5bZrnOSGPNV1k6F M4aVIPCwXHSXsZtO/5vlrAFg948MGTQoqWYyfIJMvQ1c4MR5zeyFSL3ghh7gs6HSm6Uk 3TYKM+a5llL9fHVDmQuMmP28suMqjI79xEneNy2nsuNABp8GXRTC3BuqdPZ+8u17nBtk zW0g== X-Gm-Message-State: APjAAAX7muAeZd6CQDCsWgACuCMthXqkYcJMokSEbYxvY2tfjMgwbNBC U7pHvSvzlDRKHRm1SNy3Xa952Fmj X-Google-Smtp-Source: APXvYqyKQvKR+ttBegKABTQOLYj2RrOxwuF3Ug52bwccCElxe1AB0JR2AsDyTBMClW7XRzB1B+GJgw== X-Received: by 2002:a65:6201:: with SMTP id d1mr74579054pgv.28.1555431853615; Tue, 16 Apr 2019 09:24:13 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id a12sm61352604pgq.21.2019.04.16.09.24.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2019 09:24:12 -0700 (PDT) In-Reply-To: <83y34bgldk.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 15 Apr 2019 21:43:19 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::444 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235532 Archived-At: Eli Zaretskii writes: > So I think we should do the same with get_focus_frame hook as well. Right, done. As for the comments, since we now check all of them in the generic code, I don't think there's a whole lot to do. I have the following comment; do you think it's sufficient? /* Multi-frame and mouse support hooks. */ /* Graphical window systems are expected to define all of the following hooks with the possible exception of: * query_colors * activate_menubar_hook * change_tool_bar_height_hook * set_bitmap_icon_hook * buffer_flipping_unblocked_hook */ I also added a couple missing comments to query_frame_background_color and implicit_set_name_hook: /* This hook is called to store the frame's background color into BGCOLOR. */ /* This hook is called to set the name of the GUI window by redisplay unless another name was explicitly requested. */