From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?=C3=93scar_Fuentes?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add a new user option 'ido-big-directories'. Date: Fri, 19 Apr 2019 14:23:34 +0200 Message-ID: <87k1fqqj3t.fsf@telefonica.net> References: <20190412122301.98921-1-phst@google.com> <87bm14sbko.fsf@telefonica.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="89046"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 19 14:23:52 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hHSYa-000N0P-0o for ged-emacs-devel@m.gmane.org; Fri, 19 Apr 2019 14:23:52 +0200 Original-Received: from localhost ([127.0.0.1]:56046 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHSYZ-0000dR-2i for ged-emacs-devel@m.gmane.org; Fri, 19 Apr 2019 08:23:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHSYS-0000dG-Fq for emacs-devel@gnu.org; Fri, 19 Apr 2019 08:23:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHSYR-00021C-Kk for emacs-devel@gnu.org; Fri, 19 Apr 2019 08:23:44 -0400 Original-Received: from [195.159.176.226] (port=44962 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hHSYR-0001yl-Ds for emacs-devel@gnu.org; Fri, 19 Apr 2019 08:23:43 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hHSYP-000Mm4-Vi for emacs-devel@gnu.org; Fri, 19 Apr 2019 14:23:41 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:uGCr/RdZxau38XVjgSgflh93oFQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235652 Archived-At: Philipp Stephani writes: > Am Mi., 17. Apr. 2019 um 20:58 Uhr schrieb Óscar Fuentes : >> >> Philipp Stephani writes: >> >> > This provides an alternative to 'ido-max-directory-size', for >> > directories that are statically known to be too big for Ido >> > completion. >> > >> > * lisp/ido.el (ido-big-directories): New user option. >> > (ido-directory-too-big-p): Use it. >> >> What this option does is to revert to non-ido completion when the >> regexp matches the directory name, it has nothing to do with the >> directory being big. >> >> I suggest that you rename the user option accordingly and move its use >> outside of ido-directory-too-big-p. > > This is a semantical difference: it's specifically intended to mark > directories as big, and Ido shows "too big" when attempting to > complete such a directory, so I think the name is warranted. Since this feature depends on name matching and nothing else, presuming that its only use is for signaling big directories is projecting your motivations for implementing it on the rest of the users' needs. No functionality is lost by turning this from "switch off ido for directories whose name matches this regexp because they are big" into "switch off ido for directories whose name matches this regexp". Using the appropriate name for the defcustom and placing the check on a more general site you can convey the full applicability of the feature. My 0.02 cents.