From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#35368: [PATCH v2] Do potentially destructive operations in prepare-commit-msg Date: Tue, 14 May 2019 18:09:40 -0400 Message-ID: <87k1esg02j.fsf@gmail.com> References: <20190421200313.26202-1-Hi-Angel@yandex.ru> <20190421201730.30905-1-Hi-Angel@yandex.ru> <1557868922.32614.0@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="33929"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 35368@debbugs.gnu.org To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 15 00:10:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQfcn-0008e1-TM for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 May 2019 00:10:18 +0200 Original-Received: from localhost ([127.0.0.1]:55684 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQfcf-0001Ai-U7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2019 18:10:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQfcZ-0001Ac-LJ for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 18:10:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQfcY-0006ZE-PQ for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 18:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36622) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQfcY-0006Yu-Lc for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 18:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQfcY-0007CH-AX for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 18:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2019 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35368 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35368-submit@debbugs.gnu.org id=B35368.155787179027642 (code B ref 35368); Tue, 14 May 2019 22:10:02 +0000 Original-Received: (at 35368) by debbugs.gnu.org; 14 May 2019 22:09:50 +0000 Original-Received: from localhost ([127.0.0.1]:50166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQfcM-0007Bm-7Z for submit@debbugs.gnu.org; Tue, 14 May 2019 18:09:50 -0400 Original-Received: from mail-it1-f174.google.com ([209.85.166.174]:33236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQfcJ-0007BX-Ko for 35368@debbugs.gnu.org; Tue, 14 May 2019 18:09:49 -0400 Original-Received: by mail-it1-f174.google.com with SMTP id u16so3843625itc.0 for <35368@debbugs.gnu.org>; Tue, 14 May 2019 15:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=mD7Yp5AXXFVdgZ3OmenA8dVCRF59M1AZoq20f9a7Lic=; b=BKGZE4ZZCsq52kFFZ/NIwv4bqQhwTTeqwf+KWbd9crxSM4KmFiuU0zgy31IIlZ5/2d cjH6HSp97n1dSPlNwACy4lkIu1jevqeu+GlcByByd/rB8w284TNdrp7OJKVFPxz2disX b2RU9AozYLI0ka5UjUU1XsGIbQ7TY01+FHr81o6GFvcKyJlZtPCuXGPyHdDzipgUPVMq R9bxd9PVahOLA3OSVrGDd2RL7FVLOFFTfaf7sxZi+RsznFQB/AshJdhnc1KwXzLKai/E e6BwzKylLhGtQljjP6paXXqJ77jXEJCJQhewke+6NrXlxbNZpk3pbdkgTtHVif4Z2GUD N24A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=mD7Yp5AXXFVdgZ3OmenA8dVCRF59M1AZoq20f9a7Lic=; b=MAR5ApdyLpJ+zt4isH3R15x6ZsfUmP6atP4Aw4hh9CND6YtLcGG/+PK//hFAc9Ye02 V4fr5YW+UAzvBM2w344Y6IJvhLVMv4WxhQd9qyeulhdwfzg1WzqUy6S0KJzfUgg+ivq/ 3Sq4k2BaZ8kDqnoi74XnjxVR9Ce3xITJmEuG0Yi6Rj6NARx+wOZYL3MI7BB0lj5/eGqu ncYfgk0XzoTCHfFjIGZP3OdWQ6slYdzHKg63tAAiph4wHwKyGpaZInc2mi93wyPqL6jN soew8WhsEd07/WjSHKijY88f2hLoX/3M+qxzd5e+8guUbD+jZam0epjOhiz4OM+/FEbx dMvA== X-Gm-Message-State: APjAAAUiOJGUxqWNSA9mSL3ayNh8VDMYGTIe57WIc9bZ2haiKcBH7eNy Ftyx92nCmjbnVGRMJxMAbS7WViCd X-Google-Smtp-Source: APXvYqw0uuD/laX5WX2l0a+hM6pGHkJox/FpCeDPm2AeyBH7hWgcTEXCa6u39+k4db6f7QwBoGunXA== X-Received: by 2002:a24:194c:: with SMTP id b73mr5355398itb.157.1557871781905; Tue, 14 May 2019 15:09:41 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id i25sm61877ioh.23.2019.05.14.15.09.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 May 2019 15:09:41 -0700 (PDT) In-Reply-To: <1557868922.32614.0@yandex.ru> (Konstantin Kharlamov's message of "Wed, 15 May 2019 00:22:02 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159296 Archived-At: Konstantin Kharlamov writes: > I took that part of code from the current `commit-msg`. And if you > think it's unnecessary, then it's unnecessary as well in the current > `commit-msg`. You didn't take the awk code in commit-msg that actually uses the at_sign and cent_sign variables, so I don't think that follows.