all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] master fc2da0d: Gnus: Automatically render text/calendar in a human-friendly way
       [not found] ` <20190329124636.F3B2320949@vcs0.savannah.gnu.org>
@ 2019-03-29 13:55   ` Basil L. Contovounesios
  2019-03-29 14:05     ` Stefan Monnier
  0 siblings, 1 reply; 5+ messages in thread
From: Basil L. Contovounesios @ 2019-03-29 13:55 UTC (permalink / raw)
  To: emacs-devel; +Cc: Stefan Monnier

monnier@iro.umontreal.ca (Stefan Monnier) writes:

> diff --git a/lisp/gnus/mm-decode.el b/lisp/gnus/mm-decode.el
> index b689b51..3f25541 100644
> --- a/lisp/gnus/mm-decode.el
> +++ b/lisp/gnus/mm-decode.el
> @@ -261,13 +262,13 @@ before the external MIME handler is invoked."
>      ("application/x-.?tar\\(-.*\\)?" mm-archive-dissect-and-inline identity)
>      ("application/zip" mm-archive-dissect-and-inline identity)
>      ("audio/wav" mm-inline-audio
> -     (lambda (handle)
> -       (and (or (featurep 'nas-sound) (featurep 'native-sound))
> +     ,(lambda (_handle)
> +       (and (fboundp 'device-sound-enabled-p)
>  	    (device-sound-enabled-p))))
>      ("audio/au"
>       mm-inline-audio
> -     (lambda (handle)
> -       (and (or (featurep 'nas-sound) (featurep 'native-sound))
> +     ,(lambda (_handle)
> +       (and (fboundp 'device-sound-enabled-p)
>  	    (device-sound-enabled-p))))
>      ("application/pgp-signature" ignore identity)
>      ("application/x-pkcs7-signature" ignore identity)

I'm just curious: where do nas-sound/native-sound/device-sound-enabled-p
come from?  Are they XEmacs artefacts?  Can/should they eventually be
changed to rely on play-sound et al.?

Thanks,

-- 
Basil



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Emacs-diffs] master fc2da0d: Gnus: Automatically render text/calendar in a human-friendly way
  2019-03-29 13:55   ` [Emacs-diffs] master fc2da0d: Gnus: Automatically render text/calendar in a human-friendly way Basil L. Contovounesios
@ 2019-03-29 14:05     ` Stefan Monnier
  2019-05-17 13:39       ` Basil L. Contovounesios
  0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2019-03-29 14:05 UTC (permalink / raw)
  To: emacs-devel

>> diff --git a/lisp/gnus/mm-decode.el b/lisp/gnus/mm-decode.el
>> index b689b51..3f25541 100644
>> --- a/lisp/gnus/mm-decode.el
>> +++ b/lisp/gnus/mm-decode.el
>> @@ -261,13 +262,13 @@ before the external MIME handler is invoked."
>>      ("application/x-.?tar\\(-.*\\)?" mm-archive-dissect-and-inline identity)
>>      ("application/zip" mm-archive-dissect-and-inline identity)
>>      ("audio/wav" mm-inline-audio
>> -     (lambda (handle)
>> -       (and (or (featurep 'nas-sound) (featurep 'native-sound))
>> +     ,(lambda (_handle)
>> +       (and (fboundp 'device-sound-enabled-p)
>>  	    (device-sound-enabled-p))))
>>      ("audio/au"
>>       mm-inline-audio
>> -     (lambda (handle)
>> -       (and (or (featurep 'nas-sound) (featurep 'native-sound))
>> +     ,(lambda (_handle)
>> +       (and (fboundp 'device-sound-enabled-p)
>>  	    (device-sound-enabled-p))))
>>      ("application/pgp-signature" ignore identity)
>>      ("application/x-pkcs7-signature" ignore identity)
>
> I'm just curious: where do nas-sound/native-sound/device-sound-enabled-p
> come from?

No idea.

> Are they XEmacs artefacts?

I assume so.

> Can/should they eventually be changed to rely on play-sound et al.?

Could be (tho, doesn't play-sound suffer from the problem that
it's synchronous?)


        Stefan




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Emacs-diffs] master fc2da0d: Gnus: Automatically render text/calendar in a human-friendly way
  2019-03-29 14:05     ` Stefan Monnier
@ 2019-05-17 13:39       ` Basil L. Contovounesios
  2019-05-17 13:44         ` Lars Ingebrigtsen
  0 siblings, 1 reply; 5+ messages in thread
From: Basil L. Contovounesios @ 2019-05-17 13:39 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Lars Ingebrigtsen, emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> diff --git a/lisp/gnus/mm-decode.el b/lisp/gnus/mm-decode.el
>>> index b689b51..3f25541 100644
>>> --- a/lisp/gnus/mm-decode.el
>>> +++ b/lisp/gnus/mm-decode.el
>>> @@ -261,13 +262,13 @@ before the external MIME handler is invoked."
>>>      ("application/x-.?tar\\(-.*\\)?" mm-archive-dissect-and-inline identity)
>>>      ("application/zip" mm-archive-dissect-and-inline identity)
>>>      ("audio/wav" mm-inline-audio
>>> -     (lambda (handle)
>>> -       (and (or (featurep 'nas-sound) (featurep 'native-sound))
>>> +     ,(lambda (_handle)
>>> +       (and (fboundp 'device-sound-enabled-p)
>>>  	    (device-sound-enabled-p))))
>>>      ("audio/au"
>>>       mm-inline-audio
>>> -     (lambda (handle)
>>> -       (and (or (featurep 'nas-sound) (featurep 'native-sound))
>>> +     ,(lambda (_handle)
>>> +       (and (fboundp 'device-sound-enabled-p)
>>>  	    (device-sound-enabled-p))))
>>>      ("application/pgp-signature" ignore identity)
>>>      ("application/x-pkcs7-signature" ignore identity)
>>
>> I'm just curious: where do nas-sound/native-sound/device-sound-enabled-p
>> come from?
>
> No idea.
>
>> Are they XEmacs artefacts?
>
> I assume so.

Does that mean they can be removed?  Lars?

>> Can/should they eventually be changed to rely on play-sound et al.?
>
> Could be (tho, doesn't play-sound suffer from the problem that
> it's synchronous?)

Yes.

Thanks,

-- 
Basil



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Emacs-diffs] master fc2da0d: Gnus: Automatically render text/calendar in a human-friendly way
  2019-05-17 13:39       ` Basil L. Contovounesios
@ 2019-05-17 13:44         ` Lars Ingebrigtsen
  2019-05-18 17:13           ` Basil L. Contovounesios
  0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2019-05-17 13:44 UTC (permalink / raw)
  To: Basil L. Contovounesios; +Cc: Stefan Monnier, emacs-devel

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

>>> Are they XEmacs artefacts?
>>
>> I assume so.
>
> Does that mean they can be removed?  Lars?

Sure; go ahead.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Emacs-diffs] master fc2da0d: Gnus: Automatically render text/calendar in a human-friendly way
  2019-05-17 13:44         ` Lars Ingebrigtsen
@ 2019-05-18 17:13           ` Basil L. Contovounesios
  0 siblings, 0 replies; 5+ messages in thread
From: Basil L. Contovounesios @ 2019-05-18 17:13 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Stefan Monnier, emacs-devel

Lars Ingebrigtsen <larsi@gnus.org> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>>>> Are they XEmacs artefacts?
>>>
>>> I assume so.
>>
>> Does that mean they can be removed?  Lars?
>
> Sure; go ahead.

Done[1], thanks.

[1: 63ffb61396]: Remove XEmacs audio checks from mm-decode.el
  2019-05-18 18:12:04 +0100
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=63ffb61396042f61705a9ab97fc80515d918c7e5

-- 
Basil



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-05-18 17:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20190329124636.25598.41022@vcs0.savannah.gnu.org>
     [not found] ` <20190329124636.F3B2320949@vcs0.savannah.gnu.org>
2019-03-29 13:55   ` [Emacs-diffs] master fc2da0d: Gnus: Automatically render text/calendar in a human-friendly way Basil L. Contovounesios
2019-03-29 14:05     ` Stefan Monnier
2019-05-17 13:39       ` Basil L. Contovounesios
2019-05-17 13:44         ` Lars Ingebrigtsen
2019-05-18 17:13           ` Basil L. Contovounesios

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.