From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 36022@debbugs.gnu.org, Sven Joachim <svenjoac@gmx.de>
Subject: bug#36022: 26.2.50; errors byte-compiling gnus.el
Date: Sat, 01 Jun 2019 20:43:43 +0100 [thread overview]
Message-ID: <87k1e5ay6o.fsf@tcd.ie> (raw)
In-Reply-To: <87v9xq6bjq.fsf@gmail.com> (Noam Postavsky's message of "Fri, 31 May 2019 08:41:45 -0400")
Noam Postavsky <npostavs@gmail.com> writes:
> Sven Joachim <svenjoac@gmx.de> writes:
>
>>> | In gnus-interactive:
>>> | gnus/gnus.el:3335:15:Error: Forgot to expand macro gnus-data-header
>>> | in (gnus-data-header (gnus-data-find (gnus-summary-article-number)))
>>> | gnus/gnus.el:3337:11:Error: Forgot to expand macro gnus-data-find in (gnus-data-find (gnus-summary-article-number))
>>> | gnus/gnus.el:3337:29:Error: Forgot to expand macro gnus-summary-article-number in (gnus-summary-article-number)
>>> | make[1]: *** [Makefile:297: gnus/gnus.elc] Fehler 1
>>> `----
>>>
>>> The same error occurs on a fresh bootstrap, however I can successfully
>>> byte-compile gnus.elc with a snapshot from May 12, so something has
>>> broken in the meantime on emacs-26.
>>
>> Bisection showed that commit 134edc10367a8434167656e631865c85b5f10c42
>> ("Warn about wrong number of args for subrs (Bug#35767))" is the
>> culprit.
>
> I think this exposes what is arguably a bug in gnus.el, the
> eval-when-compile around line 2378:
>
> ;; Define some autoload functions Gnus might use.
> (eval-and-compile
>
> ;; This little mapcar goes through the list below and marks the
> ;; symbols in question as autoloaded functions.
>
> is autoloading gnus-data-header, gnus-data-find, and
> gnus-summary-article-number as functions (i.e., the TYPE arg is nil),
> even though they're actually macros.
>
> But, we shouldn't start messing with that in the release branch
Glenn already fixed this[1], right? (Thanks Glenn!)
[1: 008b263fee]: * lisp/gnus/gnus.el: Mark autoloaded macros as such.
2019-06-01 11:33:25 -0700
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=008b263feeba8951a95bec93ec0a9e263cf230f7
--
Basil
next prev parent reply other threads:[~2019-06-01 19:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 11:09 bug#36022: 26.2.50; errors byte-compiling gnus.el Sven Joachim
2019-05-31 11:29 ` Sven Joachim
2019-05-31 12:41 ` Noam Postavsky
2019-06-01 19:43 ` Basil L. Contovounesios [this message]
2019-06-01 21:11 ` Noam Postavsky
2019-06-01 21:52 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1e5ay6o.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=36022@debbugs.gnu.org \
--cc=npostavs@gmail.com \
--cc=svenjoac@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.