From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#35517: 27.0.50; Small improvements to HTML mode Date: Sun, 23 Jun 2019 11:35:29 -0700 Message-ID: <87k1dctaj2.fsf@ericabrahamsen.net> References: <87wojb5aiu.fsf@ericabrahamsen.net> <875zqoeog6.fsf@ericabrahamsen.net> <87sgs0tddx.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="58001"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35517@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 23 20:38:56 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf7OA-000Exq-7I for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 20:38:54 +0200 Original-Received: from localhost ([::1]:46390 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf7O8-0002lk-R9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 14:38:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58108) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf7LR-00025u-Eh for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 14:36:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hf7LO-0004n5-Ps for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 14:36:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41055) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hf7LO-0004mR-74 for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 14:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hf7LO-0003L8-2m for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 14:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2019 18:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35517 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35517-submit@debbugs.gnu.org id=B35517.156131495012812 (code B ref 35517); Sun, 23 Jun 2019 18:36:02 +0000 Original-Received: (at 35517) by debbugs.gnu.org; 23 Jun 2019 18:35:50 +0000 Original-Received: from localhost ([127.0.0.1]:54599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf7LB-0003Ka-Jz for submit@debbugs.gnu.org; Sun, 23 Jun 2019 14:35:49 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:51714 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf7L8-0003KH-Gg for 35517@debbugs.gnu.org; Sun, 23 Jun 2019 14:35:48 -0400 Original-Received: from localhost (unknown [172.92.212.120]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id BBE37FA05D; Sun, 23 Jun 2019 18:35:39 +0000 (UTC) In-Reply-To: (Lars Ingebrigtsen's message of "Sun, 23 Jun 2019 19:39:20 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161161 Archived-At: On 06/23/19 19:39 PM, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >>>> + (unless (or alist quiet) >>>> + (message "No attributes configured.")) >>>> + (when alist >>>> + ;; Add class and id attributes if a) the element has any >>>> + ;; other attributes configured, and b) they're not already >>>> + ;; present. >>>> + (unless (assoc-string "class" alist) >>>> + (setq alist (cons '("class") alist))) >>>> + (unless (assoc-string "id" alist) >>>> + (setq alist (cons '("id") alist)))) >>> >>> Should
s always have class/id attributes? I guess it's unusual to >>> have neither, but I find myself writing
s all the time with just >>> class. Or just id... >> >> The patch changes the default value of `html-tag-alist' as well, to add >> id and class, so that's already taken care of. > > I may well be misreading the patch, but doesn't the change above mean > that the user will be prompted for class/id when they insert a
? > That's what I was worried about... Oh, no, those are two separate things. There are now keybindings for inserting div/span, but no prompting happens until you try to insert an attribute into a div. Now it offers you id/class, whereas before it told you "No attributes configured", which I always found infuriating.