bug#28385: ert "should" macros to not be globally visible

[Lars Ingebrigtsen <larsi@gnus.org>]

Glenn Morris <rgm@gnu.org> writes:

> Now "should", "should-not", and "should-error" are globally defined as
> macros (with no "ert-" prefix). They are only useful inside ert-deftests.
> Perhaps they should steal a trick from the similar "skip-unless", which
> is not globally visible. The global definition is "ert--skip-unless",
> and the ert-deftest macro basically makes "skip-unless" an alias for
> this inside the body of a test. This seems cleaner.

When writing tests, I find it convenient that I can `C-x C-e'

  (should ...)

terms.  I mean, I could just `C-x C-e' the insides of the form instead,
but still...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no