From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#20804: 24.4; XdndDrop does not use time stamp Date: Thu, 01 Aug 2019 23:40:06 +0200 Message-ID: <87k1bwbm4p.fsf@mouse.gnus.org> References: <20150613104213.50d24f9d@pristina> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="175029"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 20804@debbugs.gnu.org To: Urs Fleisch Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 01 23:41:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htIoz-000jLI-JT for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Aug 2019 23:41:13 +0200 Original-Received: from localhost ([::1]:59344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htIoy-00029X-Gu for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Aug 2019 17:41:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54240) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htIou-00029R-CI for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 17:41:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1htIoq-0007P7-Hn for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 17:41:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46717) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1htIoo-0007O6-Kh for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 17:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1htIoo-0001tC-CL for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 17:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Aug 2019 21:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20804 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20804-submit@debbugs.gnu.org id=B20804.15646956127198 (code B ref 20804); Thu, 01 Aug 2019 21:41:02 +0000 Original-Received: (at 20804) by debbugs.gnu.org; 1 Aug 2019 21:40:12 +0000 Original-Received: from localhost ([127.0.0.1]:55538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htIo0-0001s0-DR for submit@debbugs.gnu.org; Thu, 01 Aug 2019 17:40:12 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:47018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htIny-0001rq-7y for 20804@debbugs.gnu.org; Thu, 01 Aug 2019 17:40:10 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htInu-00049U-Tt; Thu, 01 Aug 2019 23:40:09 +0200 In-Reply-To: <20150613104213.50d24f9d@pristina> (Urs Fleisch's message of "Sat, 13 Jun 2015 10:42:13 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164284 Archived-At: Urs Fleisch writes: [...] > However, I think that also the behavior of Emacs could > be improved. It does not use the time stamp which can be found in the > XdndDrop message when requesting the selection. The XDND specification > states: > > XdndDrop > > Sent from source to target to complete the drop. > > data.l[0] contains the XID of the source window. > data.l[1] is reserved for future use (flags). > data.l[2] contains the time stamp for retrieving the data. (new in > version 1) > > When passing the value found in data.l[2] as the optional time stamp > argument to x-get-selection-internal, dropping from Qt 5 works with > Emacs. I have attached a patch fixing this. > > ~~~~ > --- x-dnd.el.orig 2015-06-13 09:52:02.999811917 +0200 > +++ x-dnd.el 2015-06-13 09:53:30.808247335 +0200 > @@ -496,10 +496,12 @@ > ((equal "XdndDrop" message) > (if (windowp window) (select-window window)) > (let* ((dnd-source (aref data 0)) > + (timestamp (aref data 2)) > (value (and (x-dnd-current-type window) > (x-get-selection-internal > 'XdndSelection > - (intern (x-dnd-current-type window))))) > + (intern (x-dnd-current-type window)) > + timestamp))) > success action) (I'm going through old bug reports that have unfortunately not gotten any responses.) I'm not really familiar with how drag and drop works, but I think this sounds like it makes sense. Does anybody else with more knowledge (than me) about this area think so too? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no