From: Lars Ingebrigtsen <larsi@gnus.org>
To: Urs Fleisch <urs.fleisch@gmail.com>
Cc: 20804@debbugs.gnu.org
Subject: bug#20804: 24.4; XdndDrop does not use time stamp
Date: Thu, 01 Aug 2019 23:40:06 +0200 [thread overview]
Message-ID: <87k1bwbm4p.fsf@mouse.gnus.org> (raw)
In-Reply-To: <20150613104213.50d24f9d@pristina> (Urs Fleisch's message of "Sat, 13 Jun 2015 10:42:13 +0200")
Urs Fleisch <urs.fleisch@gmail.com> writes:
[...]
> However, I think that also the behavior of Emacs could
> be improved. It does not use the time stamp which can be found in the
> XdndDrop message when requesting the selection. The XDND specification
> <http://www.newplanetsoftware.com/xdnd/> states:
>
> XdndDrop
>
> Sent from source to target to complete the drop.
>
> data.l[0] contains the XID of the source window.
> data.l[1] is reserved for future use (flags).
> data.l[2] contains the time stamp for retrieving the data. (new in
> version 1)
>
> When passing the value found in data.l[2] as the optional time stamp
> argument to x-get-selection-internal, dropping from Qt 5 works with
> Emacs. I have attached a patch fixing this.
>
> ~~~~
> --- x-dnd.el.orig 2015-06-13 09:52:02.999811917 +0200
> +++ x-dnd.el 2015-06-13 09:53:30.808247335 +0200
> @@ -496,10 +496,12 @@
> ((equal "XdndDrop" message)
> (if (windowp window) (select-window window))
> (let* ((dnd-source (aref data 0))
> + (timestamp (aref data 2))
> (value (and (x-dnd-current-type window)
> (x-get-selection-internal
> 'XdndSelection
> - (intern (x-dnd-current-type window)))))
> + (intern (x-dnd-current-type window))
> + timestamp)))
> success action)
(I'm going through old bug reports that have unfortunately not gotten
any responses.)
I'm not really familiar with how drag and drop works, but I think this
sounds like it makes sense. Does anybody else with more knowledge (than
me) about this area think so too?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-08-01 21:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-13 8:42 bug#20804: 24.4; XdndDrop does not use time stamp Urs Fleisch
2019-08-01 21:40 ` Lars Ingebrigtsen [this message]
2020-01-20 7:44 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1bwbm4p.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=20804@debbugs.gnu.org \
--cc=urs.fleisch@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.