From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37095: [PATCH] Save match data in ucs-normalize-region Date: Fri, 23 Aug 2019 05:51:29 +0200 Message-ID: <87k1b4sfni.fsf@mouse.gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="258234"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37095@debbugs.gnu.org To: Akinori MUSHA Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 23 05:52:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i10cX-00152s-TB for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 05:52:14 +0200 Original-Received: from localhost ([::1]:51166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i10cV-0006gb-K7 for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Aug 2019 23:52:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36520) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i10cN-0006g9-5E for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 23:52:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i10cM-0006nE-27 for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 23:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58150) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i10cL-0006n7-Uw for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 23:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i10cL-0005DJ-QV for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 23:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 03:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37095 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37095-submit@debbugs.gnu.org id=B37095.156653229519992 (code B ref 37095); Fri, 23 Aug 2019 03:52:01 +0000 Original-Received: (at 37095) by debbugs.gnu.org; 23 Aug 2019 03:51:35 +0000 Original-Received: from localhost ([127.0.0.1]:38735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i10bv-0005CO-Cc for submit@debbugs.gnu.org; Thu, 22 Aug 2019 23:51:35 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:39452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i10bs-0005CG-Uj for 37095@debbugs.gnu.org; Thu, 22 Aug 2019 23:51:33 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i10bp-0003Se-K6; Fri, 23 Aug 2019 05:51:31 +0200 In-Reply-To: (Akinori MUSHA's message of "Tue, 20 Aug 2019 16:18:06 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165628 Archived-At: Akinori MUSHA writes: > A patch generated by git format-patch is attached below, which simply > wraps `ucs-normalize-region` with `save-match-data`. > > I'm a user of the Emacs Mac port by mituharu was investigating a bug > where dired fails to open a certain local directory on macOS. The > error was raised at `replace-match` in the `insert-directory` > function: > > ``` > (when (re-search-forward "^ *\\(total\\)" nil t) > (let ((available (get-free-disk-space "."))) > (when available > ;; Replace "total" with "used", to avoid confusion. > (replace-match "total used in directory" nil nil nil 1) > ``` > > And it turned out the match data changed after returning from > `get-free-disk-space` and that was why `replace-match` failed. You don't say what Emacs version you're reporting this bug for, but the following patch was applied in February 2018 to the Emacs trunk, so I think this problem has been fixed by now: diff --git a/lisp/files.el b/lisp/files.el index 91aa95d631..75d3b7b1e7 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -6473,9 +6473,10 @@ get-free-disk-space space (normally, the number of free 1KB blocks). If DIR's free space cannot be obtained, this function returns nil." - (let ((avail (nth 2 (file-system-info dir)))) - (if avail - (format "%.0f" (/ avail 1024))))) + (save-match-data + (let ((avail (nth 2 (file-system-info dir)))) + (if avail + (format "%.0f" (/ avail 1024)))))) ;; The following expression replaces `dired-move-to-filename-regexp'. (defvar directory-listing-before-filename-regexp -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no