From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#36940: tests slowness and failure after recent Tramp changes Date: Mon, 26 Aug 2019 10:44:06 +0200 Message-ID: <87k1b0wc2x.fsf@gmx.de> References: <57e233fe-19e9-6eac-7fd5-7e181879d4df@cs.ucla.edu> <87h86uh2l6.fsf@gmx.de> <1bec46f5-01e7-5ea4-5562-501185d80ecf@cs.ucla.edu> <87v9vaf4sk.fsf@gmx.de> <87r25xf1dn.fsf@gmx.de> <8736ibkbne.fsf@gmx.de> <87mughfj96.fsf@gmx.de> <470b50ab-6658-e3cb-cd59-916c398c442f@cs.ucla.edu> <87h86of1tm.fsf@gmx.de> <87v9v0avhm.fsf@gmx.de> <8736hryoi1.fsf@gmx.de> <8736hpxy87.fsf@gmx.de> <661631ef-57ff-a907-d69c-b78aebfa68b9@cs.ucla.edu> <87y2zhw6eq.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="193822"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Stefan Kangas , 36940@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 26 10:45:32 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2Ad2-000oHl-6b for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Aug 2019 10:45:32 +0200 Original-Received: from localhost ([::1]:50962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2Acz-0002kP-TX for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Aug 2019 04:45:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49991) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2AcZ-0002jf-8K for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 04:45:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2AcY-0002xL-5G for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 04:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36764) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2AcX-0002xF-UY for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 04:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i2AcX-0004il-QF for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 04:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Aug 2019 08:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36940 X-GNU-PR-Package: emacs Original-Received: via spool by 36940-submit@debbugs.gnu.org id=B36940.156680907218090 (code B ref 36940); Mon, 26 Aug 2019 08:45:01 +0000 Original-Received: (at 36940) by debbugs.gnu.org; 26 Aug 2019 08:44:32 +0000 Original-Received: from localhost ([127.0.0.1]:45585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2Ac4-0004hi-5w for submit@debbugs.gnu.org; Mon, 26 Aug 2019 04:44:32 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:42497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2Ac1-0004hV-LR for 36940@debbugs.gnu.org; Mon, 26 Aug 2019 04:44:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1566809049; bh=g6m3uA8chf7F36l5TfxP9FpzGZPBf9pQ1EAPBo4XLGU=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=FSpRNBVFZZZDIfxWTiqFfdKfE9L+aPOe+mEZ7fx9LFRRk1THLMByZK43bFjcJ2er3 OMJfNVpBvNdRQbE8B9lG82LLWnnZfRxHZ9Ow2Jz+5RbIMtzocO1NKJwW60tn5lujgw 55ocC8F+1+StuKMix9sWwzYpnk+8BTqOVKiVmsVI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([178.20.95.58]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MPZuP-1i6HCi0j1V-004iBE; Mon, 26 Aug 2019 10:44:09 +0200 In-Reply-To: (Paul Eggert's message of "Sun, 25 Aug 2019 13:36:46 -0700") X-Provags-ID: V03:K1:k+eUIojBDFPcbT5tw+zfUP2WaAA0mSo3naMt5hiHZ/lsf4/X5G3 QPxgsql6jlF6CmBCXA611TgCYDCtUfz/26PA3C1osO5n3RBe4Wi3HbvLMJblFxJi1PavIaL ag11DfD/RHpZedUBNhprqrmkXd2sSbk0ImtGj+h4BUZFPJEptXxB2T78dC/QTnEEsH6MvjE +ScvlxWtgRIIUtLBX/fpQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:NuwiMa7cK8M=:bOUGHniW8WMTgPE8PviiW6 S70tURx/qlP0vLUhu5K/7LTU1kDD+UmyyrLOaZLnyrhyWfpXihsc8esjz36HPG3O1zSQIz1yY Jz9+OASuLlXS+vUIGOIGTZfXi2Oe9nXQBXukoQEdfI/k3E2/phDnsbeZ8S9ss1sy4sCNdpT5j Y0MS2hZMpoX421fGyAH7ikydsGNntFWDscAR8e9Wl/NlUMrYhfdm8DFFhQdx+X2QQZ8Q9HQSq 1tZtREV3w/+3JjDdFkvE/ajfIskkG3KGawsnfUZKpyKZH0NbMYscxNSStNhV0LZXdavcyTkO8 yoWQMrL3blwfbNR2JhRksT2UfKLqj2ba/7Ryfn+D367TnvL3sFwRWUUAWb47XZcwKY4Z6FvWv wiRB6Tsc9qbTb9KI5EMbJ+CJxGtFyzVWdmOKtxluC44KIEWgVYj4K/d4Aqbe11KhzOHuAd/cq x06wK2OeLf2YIULO2T8JFsPrzCPcnmUk4v/lG6ub9ughZp9MLSIb4KYSya3311b/fWHYBfiUW bJ7g3S59jH8dVzGiwohHk6LQXC7oXLUSv7qq6FLUaGR5Ggw5bPleGsZt1AsnIwwhOwFu+dL8O 7oojBIqFtWAPAnQq2QA14tW1N3gnTC42RRDF4NBizJVRuYpsJElSOaCHlQN6IdkuPl6NFUYfD Z1a6o6n3s3rkNBV//ERzPJAA/amxPiYnpRZqfm0US2x3BDuH3UlSw0tv5R8cKEI7EVfijsjrq VxpTjhdjtNtZ2DE79Pa7MKqBN7o4w9N/wk0j7posOlEQho8hKjbjR9hxT6aw0oYN9E7tl2Ad X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165893 Archived-At: Paul Eggert writes: Hi Paul, > For example, suppose the inode number is 2**63 - 512 and the Perl code > generates "9223372036854775296.0", which is exact. When the Emacs Lisp > reader converts this to double it must round since there is no exact > double representation, and rounding yields 2**63, i.e., > 9223372036854775808.0, which is off by 512. > > A simple fix is to change the Perl code to omit the trailing ".0", > e.g., "9223372036854775296" rather than "9223372036854775296.0". This > will cause the Emacs Lisp reader in master to return an exact integer > instead of a float, thus avoiding the rounding error. This fix will > still suffer from the same rounding errors in older Emacs releases > where the reader returns a float for integers out of fixnum range, but > it shouldn't hurt those older releases and it should fix the problem > in master. Indeed, up to Emacs 26 this rounding error still applies. With master (improved big number support) it works fine. > Please see attached patch. I haven't tested or installed the patch as > I don't use Tramp, but you should be able to test it with something > like this: OK for me. You might install the patch, and also adapt the templates in `tramp-do-file-attributes-with-stat and' `tramp-do-directory-files-and-attributes-with-stat'. >> I haven't seen any code in Emacs which needs this slot. > > It's used by ede--inode-for-dir, eshell-shuffle-files, ls-lisp-format, > find-lisp-format, nnmaildir--group-maxnum, > nnmaildir--new-number. `ls-lisp-format' and `find-lisp-format' don't count, they *provide* the inode number; they don't *use* it. > Typical uses are to determine whether two > directory entries identify the same file, e.g., (equal > (file-attribute-inode-number file1) (file-attribute-inode-number > file2)) or to use it in a hash table. `ede--inode-for-dir' and `nnmaildir--*' are a little bit lazy, they don't compare the device number. Might be acceptable; one could assume that a project dir or a mail dir handle only files on the same file system. Best regards, Michael.