From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Mon, 11 Nov 2019 20:03:45 +0100 Message-ID: <87k186nsku.fsf@bernoul.li> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="249332"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.1.0; emacs 27.0.50 Cc: 37774@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 11 20:04:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iUEzC-0012ay-BK for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Nov 2019 20:04:26 +0100 Original-Received: from localhost ([::1]:56446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUEzB-0001aL-2H for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Nov 2019 14:04:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36991) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUEyp-0001aD-MK for bug-gnu-emacs@gnu.org; Mon, 11 Nov 2019 14:04:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUEyo-0005hV-Ky for bug-gnu-emacs@gnu.org; Mon, 11 Nov 2019 14:04:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47173) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iUEyo-0005h7-9i for bug-gnu-emacs@gnu.org; Mon, 11 Nov 2019 14:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iUEyo-0006Zl-2x for bug-gnu-emacs@gnu.org; Mon, 11 Nov 2019 14:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Nov 2019 19:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157349902925255 (code B ref 37774); Mon, 11 Nov 2019 19:04:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 11 Nov 2019 19:03:49 +0000 Original-Received: from localhost ([127.0.0.1]:55994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUEyb-0006ZH-Cf for submit@debbugs.gnu.org; Mon, 11 Nov 2019 14:03:49 -0500 Original-Received: from mail.hostpark.net ([212.243.197.30]:44992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUEyZ-0006Z8-Ee for 37774@debbugs.gnu.org; Mon, 11 Nov 2019 14:03:48 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id C36891669C; Mon, 11 Nov 2019 20:03:45 +0100 (CET) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id ge0uHt8Tl8Fo; Mon, 11 Nov 2019 20:03:45 +0100 (CET) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 4BFE0168B8; Mon, 11 Nov 2019 20:03:45 +0100 (CET) In-reply-to: <87zhh2ofc9.fsf@bernoul.li> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171438 Archived-At: > I'll be back. Currently if a package sets `:extend t` for some face, then that has no effect if some theme modifies that face without explicitly repeating the `:extend t'. Lets use `hl-line' as an example. Enable `hl-line-mode' and visit the definition of the `hl-line' face. You will notice that it `:extend t' and that the highlighting indeed extends to the window edge. Then enable any theme and notice how the highlighting no longer extends to the edge of the window. That's because the theme does something like: '(hl-line ((t (:background "lightgrey")))) as opposed to '(hl-line ((t (:background "lightgrey" :extend t)))) I mentioned this elsewhere and Dmitry said that this is not how it is supposed to work and if it did work that way then that would be a bug. He also mentioned that this had been discussed here but I have been reading this issue from the top while listening to all the way to "The End" of the The Very Best Of The Doors and I still have not read anything about something being done to prevent the need to repeat the extend setting. Message #104 mentions a variation of this issue, but so far I haven't gotten to a message saying "okay lets add a hack to deal with this" yet, so I figured I would ask: Should it be unnecessary that each and every theme does: - '(hl-line ((t (:background "lightgrey")))) + '(hl-line ((t (:background "lightgrey" :extend t)))) ?