From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: No Wayman Newsgroups: gmane.emacs.bugs Subject: bug#39805: 28.0.50; scan-sexps (scan_lists) incorrectly parsing circular list Date: Thu, 27 Feb 2020 23:01:41 -0500 Message-ID: <87k147l5qy.fsf@gmail.com> References: <87wo89ghix.fsf@gmail.com> <87pne0ajy3.fsf@gmail.com> <87mu94kkrq.fsf@gmail.com> <87a753a19c.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="98868"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.3.9; emacs 28.0.50 Cc: 39805@debbugs.gnu.org, No Wayman To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 28 05:02:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j7Wqq-000Pc4-EU for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Feb 2020 05:02:12 +0100 Original-Received: from localhost ([::1]:41456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7Wqp-0007GO-6q for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Feb 2020 23:02:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40220) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7Wqh-0007GB-NN for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 23:02:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7Wqg-0003kQ-KA for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 23:02:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54537) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j7Wqg-0003kJ-Gc for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 23:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j7Wqg-0007Ec-Cn for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 23:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: No Wayman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Feb 2020 04:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39805 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 39805-submit@debbugs.gnu.org id=B39805.158286251027787 (code B ref 39805); Fri, 28 Feb 2020 04:02:02 +0000 Original-Received: (at 39805) by debbugs.gnu.org; 28 Feb 2020 04:01:50 +0000 Original-Received: from localhost ([127.0.0.1]:60510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7WqU-0007E6-4H for submit@debbugs.gnu.org; Thu, 27 Feb 2020 23:01:50 -0500 Original-Received: from mail-qk1-f174.google.com ([209.85.222.174]:34550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7WqS-0007Dp-F3 for 39805@debbugs.gnu.org; Thu, 27 Feb 2020 23:01:48 -0500 Original-Received: by mail-qk1-f174.google.com with SMTP id 11so1810865qkd.1 for <39805@debbugs.gnu.org>; Thu, 27 Feb 2020 20:01:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:message-id :date:mime-version; bh=ubhBFXBjyu6WmmATEV2FkYiXihI/8YWgsjYue/jH1ZA=; b=IHinJRS80i9xti+uQzVvwcxYXIjtVlAP5bqtbnZ+7NLvbf7LARW6GuALraFOS/mXmD eGgvfGyltdavqDwe8XfpxIwbWAeEJqGwOgyCdB6CBKSks24Uhkw0Lh91Y2oJm0iK33y6 m0/ePyESHZCez4h0n9RHeVn4R2/dky6w/8g7tTgmL68nY8E0o3Vbj8jo5heuMXE4w6dy lmPSD2iWolhRhj4HQaMup3WqRW/yyY447LODArVhBT5YNTkfIF3G//m+mIcMsKnNfOII fApxPguFs7X6iE/T17AsSqlWMXDROiAn+0iC5ugnYpIGoOXsaMF3UjtKv5BOkg9gUapz a1Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=ubhBFXBjyu6WmmATEV2FkYiXihI/8YWgsjYue/jH1ZA=; b=FJdhR0sie5zPKZTNccoLS3IXIGoW0LHZnG7BJFImCF/05AO/dV7NJ6DP2P8f37zb6i A0sBuCQwKBawYamOVSq/4jD5R9OP6zl0Ut5rb/0ff4NHwduSoT0MTo/DfPpWXauXxgoZ JJb9CMuWNCo2GdqTjeyWG4M31dgGMlM7/2S/RQzWmNagi07YX15paPwNNpP1dfVpf1rx 1GCFFJ81g+3yzhrQRjpUojWpS3Qtex3ZgQIlFMaI8YcBnOxuQjDBw/pTNXp3QjSh3tL/ JFFiSbH/GIY1BJIOkd16sTk0A/Edfwi+n/r526JWiELNgcagxLQvfBnOaySzHo68RNXQ ej2A== X-Gm-Message-State: APjAAAUEGx5eGRXEDnvvxq+lSbbIIALs3aT373eCFDa54WroNPHC2Ox9 0Os67TY/MEAmx+r/gtoVu4pBSnXE X-Google-Smtp-Source: APXvYqz5RvryktJpjjfEVEGVgzdfXY5jq6PfnTE+0VEmDEjyaW9V7uS9bDDp/iFYSgH/M2yewb08RA== X-Received: by 2002:a37:9245:: with SMTP id u66mr2862048qkd.102.1582862502770; Thu, 27 Feb 2020 20:01:42 -0800 (PST) Original-Received: from arch (c-69-141-147-3.hsd1.nj.comcast.net. [69.141.147.3]) by smtp.gmail.com with ESMTPSA id w83sm3797656qkb.83.2020.02.27.20.01.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 20:01:42 -0800 (PST) In-reply-to: <87a753a19c.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176549 Archived-At: > Mostly yes, but IMO it's kind of over-engineered. I would do > just: > > (defun workaround/describe-variable-print-bug > (original-function &rest args) > "Put temp buffer in emacs-lisp-mode before `pp-buffer'. > https://debbugs.gnu.org/39805#8" > (advice-add #'pp-buffer :before #'emacs-lisp-mode) > (unwind-protect > (apply original-function args) > (advice-remove #'pp-buffer #'emacs-lisp-mode))) > > (when (= emacs-major-version 26) ;; Work around Bug#39805. > (advice-add #'describe-variable :around > #'workaround/describe-variable-print-bug)) I assumed mine was doing a more than it needed to. Thanks again for the patch and the workaround.