all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: No Wayman <iarchivedmywholelife@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 39805@debbugs.gnu.org, No Wayman <iarchivedmywholelife@gmail.com>
Subject: bug#39805: 28.0.50; scan-sexps (scan_lists) incorrectly parsing circular list
Date: Thu, 27 Feb 2020 23:01:41 -0500	[thread overview]
Message-ID: <87k147l5qy.fsf@gmail.com> (raw)
In-Reply-To: <87a753a19c.fsf@gmail.com>

> Mostly yes, but IMO it's kind of over-engineered.  I would do 
> just:
>
>     (defun workaround/describe-variable-print-bug 
>     (original-function &rest args)
>       "Put temp buffer in emacs-lisp-mode before `pp-buffer'.
>     https://debbugs.gnu.org/39805#8"
>       (advice-add #'pp-buffer :before #'emacs-lisp-mode)
>       (unwind-protect
>         (apply original-function args)
>         (advice-remove #'pp-buffer #'emacs-lisp-mode)))
>
>     (when (= emacs-major-version 26) ;; Work around Bug#39805.
>       (advice-add #'describe-variable :around
>               #'workaround/describe-variable-print-bug))

I assumed mine was doing a more than it needed to.
Thanks again for the patch and the workaround.





  reply	other threads:[~2020-02-28  4:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 21:33 bug#39805: 28.0.50; scan-sexps (scan_lists) incorrectly parsing circular list No Wayman
2020-02-27  1:38 ` Noam Postavsky
2020-02-27 17:22   ` No Wayman
2020-02-28  2:34     ` Noam Postavsky
2020-02-28  4:01       ` No Wayman [this message]
2020-03-04  3:09       ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k147l5qy.fsf@gmail.com \
    --to=iarchivedmywholelife@gmail.com \
    --cc=39805@debbugs.gnu.org \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.