From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Simon Pugnet Newsgroups: gmane.emacs.bugs Subject: bug#41544: 26.3; Possible incorrect results from color-distance Date: Thu, 04 Jun 2020 07:15:55 +0100 Message-ID: <87k10ngxus.fsf@polaris64.net> References: <5C4A633D-8222-4439-BE37-9B8674F1DA6D@acm.org> <87r1v2aat3.fsf@tromey.com> <9902865C-01B4-4E50-A433-DBC8B8311234@acm.org> <83tuzueogo.fsf@gnu.org> <6272275C-560C-4437-90F1-2A8294D27019@acm.org> <83o8q2elja.fsf@gnu.org> <83mu5mel4o.fsf@gnu.org> <77F1DDD3-A69F-40ED-902D-74986D5E6596@acm.org> <83y2p5cumz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="100056"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.2.0; emacs 26.3 Cc: tom@tromey.com, 41544@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 04 10:37:03 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jglN1-000Pzg-4S for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jun 2020 10:37:03 +0200 Original-Received: from localhost ([::1]:49266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jglN0-0001Eg-87 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jun 2020 04:37:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jglM2-0000Ld-T6 for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2020 04:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33548) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jglM2-0007CQ-Ip for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2020 04:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jglM2-0002E5-Ga for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2020 04:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Simon Pugnet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2020 08:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41544-submit@debbugs.gnu.org id=B41544.15912597298490 (code B ref 41544); Thu, 04 Jun 2020 08:36:02 +0000 Original-Received: (at 41544) by debbugs.gnu.org; 4 Jun 2020 08:35:29 +0000 Original-Received: from localhost ([127.0.0.1]:45090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jglLV-0002Cr-A4 for submit@debbugs.gnu.org; Thu, 04 Jun 2020 04:35:29 -0400 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:37853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgjAc-0007FM-RH for 41544@debbugs.gnu.org; Thu, 04 Jun 2020 02:16:07 -0400 Original-Received: by mail-wr1-f49.google.com with SMTP id x13so4727463wrv.4 for <41544@debbugs.gnu.org>; Wed, 03 Jun 2020 23:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=xYnd9YOqhDKnL5B0JSkg6Pv1Nuup0wKTcQ56pr8Wusk=; b=dQ7VBvfrJ8C9WwYgZjINk6ku/848Lz/gFmxhBy/h4xppQjvX4O7DLwHRSN/Xkvi5kt 0uHWEXRYYP7PVSU9uoCrnqi2kzO9alzAO1OFIRG8UNsUZfHeEy3rRcSAtWaWAXww7Oot UEYxCLEg4L6DkXiorS7aI3gQ5pO7h83c3eYRA3gWTHBL/Lia3I/NJNdNbn903Cicdm2Q w6jG7lyJdIUDNnMwgMY0frf7qxloCmW76EAdm7Shm+t+iTovJaOFn+9M8JZC6nGllKxt Mqqz/h+raP+b6r4F6piXNARkzNuK1oLEtricaMygyu2NV2yfyqilTHL32ilLJzHHVgwx KSMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=xYnd9YOqhDKnL5B0JSkg6Pv1Nuup0wKTcQ56pr8Wusk=; b=GY2qovh8aPJpnqvH/SrwktoiDvHLBenuuSihNzIIhoXjBAAr+27Zn7IGzEHIgQeOvg eiPXnexV9lCM3iYZJGXtmltXxAs8OLWqzvBM2kvoxuW2PtjRYGyDzikj2zsi2uEqgaMA epPSJo3dEleZQwdXkOJXLPPeoeCsQn5d1RjWqaIfh3sAzkJA1lh+DXekvt6xfS8LMys4 AClQ0XSDUH2WObJKUCmKzRxuccCVaAK/naAsDIIsYcp1pzwFqeacjJheIDI7fl5irmwE YRm4ccPYXb83NmSqQAu1M1vgIuKthPpmCISh7Nj7jBsXfnvp5TawTmyqh1Vu4/zKlX7j 1ZHw== X-Gm-Message-State: AOAM532V2RxfwHbL/fAqpbI07GNx9TFthwozH/13EPTcxnscMT39k3Wk kD4/0skzI0gNJW51gO4RxSKEcCbnTCE= X-Google-Smtp-Source: ABdhPJytrl6eLZpYmd0lql9CGLXYVByK3+WbHuBZOgN21jjwK05ow3xrCY7T5V1Wopp9xzRY+5Oevw== X-Received: by 2002:adf:dc8e:: with SMTP id r14mr2599753wrj.333.1591251360744; Wed, 03 Jun 2020 23:16:00 -0700 (PDT) Original-Received: from karnak (141-136-153-177.dsl.iskon.hr. [141.136.153.177]) by smtp.gmail.com with ESMTPSA id i3sm6360142wrm.83.2020.06.03.23.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2020 23:15:59 -0700 (PDT) In-reply-to: X-Mailman-Approved-At: Thu, 04 Jun 2020 04:35:28 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181497 Archived-At: --=-=-= Content-Type: text/plain; format=flowed > Very well, it is obviously an improvement. The reason for the > current asymmetry was actually that the algorithm discarded the > low bits; what about fixing that as well? The improved accuracy > amounts to less than 1 % of difference in the return value; no > other code needs changing, and we get the symmetry for free. > Proposed patch attached. Firstly, Mattias and Eli, thank you both for investigating and dealing with this bug so quickly and thoroughly. I just noticed that the patch and commit 7e8c1a671872ef8e45057f25912594cf548639ab to master both reference the bug incorrectly in test/src/xfaces-tests.el. The comment under the new test is "Check symmetry (bug#51455)" however the bug ID is 41544. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO/eF3hYsAMj7Tab9uhNZqCwLPvkFAl7YkZsACgkQuhNZqCwL Pvk4bQ/+PH7d6d4S8fked/BaG5wrfDyc5YmaZGIMQhdllk8ghuxmTZ8fT52dZ/w5 Bhb+/+TP3Ht4p/q3HG5uKm584WFPMtDJABy+umP8KUgA1U/XKa+3uHf1QhN1CBQn Q97pqZ/kM4Q25lcUVvCdRRX3JMPp0r2cUYk9dTq9V++HLxSIiozyah2aO8oXvC1M rbNKCII4a4tVioTjgJ0035fxmERAvG+BxSlukhn953kcUvBGco9V3ZI5tgg/ZJxK JQsdycz8fnd+UR+ZVEBtM0yiH5v4KuyIG3B/S3upq9SFl4QO5SDpiffL3TAnU9CP 8gkn0OUqhTPhjTskAwHM46L6G9xteIhB8AJB3UzT5WczYlYMpeTf/M7h5zbeap5W v7ijgCARZX2QetwcdInQDQSzSqKrzU7OcZENvHY1sYpMglLK96UqMUOGge7Un5am UuKZEvWAlR1HpKdIyBruVWu0rGznfmsX3Xtef3hTUZD3mkmXh9qxGD42SHE732rn XtHS3Fzvap+HBk/N0mnZdMlDYyR+8jE1V1PniaU3ZOgp4Ozvna52hi5rqrzz6WAE 9mxmsrEpV4AhYs+zDZNvjkulGJMc9uayzA19A91IAByKEenrXvymDTiY9Eop6b3V k6ndjCH17XfYxnzfEihCnNa/iAgBx8gJRpbHxu8w9K3kQrZIEvo= =6bM1 -----END PGP SIGNATURE----- --=-=-=--