From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#42210: Add -other-window variants of project-prefix-map commands Date: Mon, 06 Jul 2020 03:19:16 +0300 Organization: LINKOV.NET Message-ID: <87k0zhv6kb.fsf@linkov.net> References: <87blkw5cd3.fsf@iris.silentflame.com> <87tuymh4k9.fsf@iris.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34230"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42210@debbugs.gnu.org, dgutov@yandex.ru To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 06 02:56:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jsFQa-0008ik-LL for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Jul 2020 02:56:12 +0200 Original-Received: from localhost ([::1]:56010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsFQZ-0002ex-EN for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jul 2020 20:56:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsFQR-0002dl-8W for bug-gnu-emacs@gnu.org; Sun, 05 Jul 2020 20:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49835) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsFQQ-0003jb-1J for bug-gnu-emacs@gnu.org; Sun, 05 Jul 2020 20:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jsFQP-0002Wo-Vm for bug-gnu-emacs@gnu.org; Sun, 05 Jul 2020 20:56:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87tuymh4k9.fsf@iris.silentflame.com> Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jul 2020 00:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42210 X-GNU-PR-Package: emacs Original-Received: via spool by 42210-submit@debbugs.gnu.org id=B42210.15939969349679 (code B ref 42210); Mon, 06 Jul 2020 00:56:01 +0000 Original-Received: (at 42210) by debbugs.gnu.org; 6 Jul 2020 00:55:34 +0000 Original-Received: from localhost ([127.0.0.1]:33148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsFPy-0002W0-8b for submit@debbugs.gnu.org; Sun, 05 Jul 2020 20:55:34 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:43553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsFPw-0002Vg-In for 42210@debbugs.gnu.org; Sun, 05 Jul 2020 20:55:33 -0400 X-Originating-IP: 91.129.96.187 Original-Received: from mail.gandi.net (m91-129-96-187.cust.tele2.ee [91.129.96.187]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 8C63360002; Mon, 6 Jul 2020 00:55:24 +0000 (UTC) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182761 Archived-At: > Here is a patch implementing commands under C-x 4 p. If the approach is > thought sound I can also prepare patches for C-x 5 p and C-x t p. > > I have tested the attached change except for the autoload cookies which > I am not sure will work with my new macro. And I'm not sure I should be > doing this with a macro instead of a function which calls fset -- please > advise. Thanks for the patch. On emacs-devel you said that rather than add definitions of project-find-file-other-window, etc. display-buffer-override-next-command could be used. But there is no display-buffer-override-next-command in your patch, and definitions of project-find-file-other-window etc. are still added (with the help of macro). Would it be possible to define the 'C-x 4 p' map the same way as 'C-x p p' is defined? There is a patch in https://debbugs.gnu.org/41890#127 to use the default project keymap 'C-x p' in 'C-x p p'. You could try to use the same keymap in 'C-x 4 p', and wrap the command call with display-buffer-override-next-command.