From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: eldoc error in Emacs 27 Date: Mon, 27 Jul 2020 21:03:54 +0100 Message-ID: <87k0yosp1x.fsf@gmail.com> References: <33D61A89-7C41-4160-8C79-C756635B205C@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9877"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 27 22:04:41 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k09MW-0002Tc-Sf for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Jul 2020 22:04:40 +0200 Original-Received: from localhost ([::1]:55086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k09MV-0000CU-U5 for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Jul 2020 16:04:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k09Ls-0007ws-Bl for emacs-devel@gnu.org; Mon, 27 Jul 2020 16:04:00 -0400 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:37799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k09Lq-0006KT-PA for emacs-devel@gnu.org; Mon, 27 Jul 2020 16:04:00 -0400 Original-Received: by mail-wm1-x32b.google.com with SMTP id k8so5631094wma.2 for ; Mon, 27 Jul 2020 13:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=av/Ak2NozmOrkxgPiDfVz1ZxMKxyjUUVvw7VlB4Tg+U=; b=hQwNzav+oJSLZosxjbyoY9Zl7TNMtCozFzS3THE9o7nx9u1J9U++F1YUYy0U/YiGVV f9qcR9JSN6p7ybIqLO5eI1LCoAOWt02LA/gR42JYVs1JkC7ua2t+/GlieLkba7KH+Si0 7jygfKQHYUEs6VTGHfcsb9MiDyWAGb3uRhpnkYCElkOUW/8une5Sn95BcGE55xCxHD3f C6FX9tsLCgYZfHK2Dw9eRSZTxDgrLJbrk8ZsRBi9VamekgfUkd1dnNojeWGwjnNGVsac 9RATqkb2pBtbmVCZT85jQa3UUluXCjW5zgmDEeDgW4fRly4asBNIPVVqAWX13Zz+dOUA zfJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=av/Ak2NozmOrkxgPiDfVz1ZxMKxyjUUVvw7VlB4Tg+U=; b=KZz8gTycRIOESTrrdQga5rgxKgAfyklbloZtDzjGa6ykjIF9x6qLH0rLrzgNdiU+TB OMqvM3G0ThoYAb4YyDW1vYFFa6wSVg2h+zgTXr+vhHHeRRg8WZTalFJk68OpQysXdOvd AnYUW0LqFpD8lqHk60XyqhsTs7yeKf6r80MwQW8LAgZxBeeaR39RUoyuw67JHshItpWi n46XdEGjFj77taV54YTAOFzGRjW8V/eMNPYzoK9UexcqvnTiDKGrvXFhSHIEqTpnnXc6 /G19LWep06dDaQPc6QFSHGdv/Zg66qIxqzh51jTgR53ZW2roIhTrh5vk1YBjqBx3TS8I nEuA== X-Gm-Message-State: AOAM530+PYKrUDMwb1ik5vSAWkmrzYxRuQPYOtpHGob+wLEKcoign4ir R3a60q7U32MXXJhm76Zfhwk2rg94JrI= X-Google-Smtp-Source: ABdhPJxn8sufzMf9+M3Cd8q5RzsDf/7C9CXWBM2H/SD5RIbgnbu9GSCxcWlaHiGRDn3T04FHfSradA== X-Received: by 2002:a7b:c7d5:: with SMTP id z21mr763233wmk.145.1595880237119; Mon, 27 Jul 2020 13:03:57 -0700 (PDT) Original-Received: from krug ([89.180.159.6]) by smtp.gmail.com with ESMTPSA id z127sm812246wme.44.2020.07.27.13.03.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 13:03:56 -0700 (PDT) In-Reply-To: <33D61A89-7C41-4160-8C79-C756635B205C@gmail.com> (Yuan Fu's message of "Mon, 27 Jul 2020 14:51:03 -0400") Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=joaotavora@gmail.com; helo=mail-wm1-x32b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253291 Archived-At: Yuan Fu writes: > 1.5. I looked around in that file and didn=E2=80=99t see elisp-eldoc-func= all > defined anywhere (neither can I in the old eldoc.el that comes with > Emacs 27). Thanks for reporting this. I introduced this bug. The function you get the error for is not defined in eldoc.el ? 1.5.0 but referenced there: (defun eldoc--eval-expression-setup () ;; Setup `eldoc', similar to `emacs-lisp-mode'. FIXME: Call ;; `emacs-lisp-mode' itself? (add-hook 'eldoc-documentation-functions #'elisp-eldoc-var-docstring nil t) (add-hook 'eldoc-documentation-functions #'elisp-eldoc-funcall nil t) (setq eldoc-documentation-strategy 'eldoc-documentation-default) (eldoc-mode +1)) Why is this Elisp-specific function in eldoc.el? Perhaps it shouldn't be, but eldoc.el and elisp-mode.el are so unfortunately interwined so it will have to remain there at least until we abandon Emacs 27 or make elisp-mode.el a GNU ELPA :core package, too. For now, the fix is to ensure that this function has an implementation compatible with Emacs < 28, so that if you package-install a newer ElDoc version you will not run into this problem. The FIXME comment _could_ work in theory but I think it'll just bring more problems. I'll post a simpler, safer fix, soon. In the meantime, can you make a bug report to track this? Thanks, Jo=C3=A3o