From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#41095: ERC header line Date: Wed, 29 Jul 2020 06:54:51 +0200 Message-ID: <87k0ym3opw.fsf@gnus.org> References: <87wo5q1rd4.fsf@bulbul> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39297"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41095@debbugs.gnu.org To: philip@warpmail.net (Philip K.) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 29 06:56:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0e8T-000A5G-Q1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Jul 2020 06:56:13 +0200 Original-Received: from localhost ([::1]:37592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0e8S-0003pJ-Rh for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Jul 2020 00:56:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0e8I-0003oo-Re for bug-gnu-emacs@gnu.org; Wed, 29 Jul 2020 00:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48125) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k0e8I-00057s-IM for bug-gnu-emacs@gnu.org; Wed, 29 Jul 2020 00:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k0e8I-0006QZ-GU for bug-gnu-emacs@gnu.org; Wed, 29 Jul 2020 00:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Jul 2020 04:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41095 X-GNU-PR-Package: emacs Original-Received: via spool by 41095-submit@debbugs.gnu.org id=B41095.159599851524633 (code B ref 41095); Wed, 29 Jul 2020 04:56:02 +0000 Original-Received: (at 41095) by debbugs.gnu.org; 29 Jul 2020 04:55:15 +0000 Original-Received: from localhost ([127.0.0.1]:59668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0e7W-0006PF-TV for submit@debbugs.gnu.org; Wed, 29 Jul 2020 00:55:15 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:41684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0e7U-0006Oy-BQ for 41095@debbugs.gnu.org; Wed, 29 Jul 2020 00:55:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=F4TOxXjtYxMmLo+wSq7dbVe+goPR7MBacztrHK8bAIk=; b=arJ+CqScyRvwUrZ+LI/lsOef1Q ZVtep0CQDr284OTVX/nGogt0hNGo2wpFRjlNEUUxrZzTZW62YLxnB9a7cjx3wzexfZwYdsuYk640f xBnfpo08tZg95xjOAn9umBk+lK+W7zDyN/60G2fi6MszxxdFdK1AJh79BQjgQdrdS/HA=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0e7B-00029Q-0w; Wed, 29 Jul 2020 06:55:05 +0200 In-Reply-To: <87wo5q1rd4.fsf@bulbul> (Philip K.'s message of "Tue, 05 May 2020 14:46:47 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183641 Archived-At: philip@warpmail.net (Philip K.) writes: > when trying out a dark theme I noticed that the ERC header line was out > of place. It turns out that this is because it's fore- and background > color are hard-coded to gray20 and gray90. Since these are fairly > similar to the default colours of header-line using a light > colour-scheme, I suggest inheriting it's values by default.c [...] > (defface erc-header-line > - '((t :foreground "grey20" :background "grey90")) > + '((t :inherit header-line)) > "ERC face used for the header line. This also makes the header line look less awkward in dark mode, so it makes sense to me. Applied to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no