From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34657: [PATCH] erc: fix erc-reuse-buffers (bug#40121) Date: Sun, 09 Aug 2020 12:48:16 +0200 Message-ID: <87k0y8umbz.fsf@gnus.org> References: <87lfitesdn.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10829"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 34657@debbugs.gnu.org, bandali@gnu.org To: "Mingde (Matthew) Zeng" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 09 12:49:37 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4itU-0002iE-Fr for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Aug 2020 12:49:36 +0200 Original-Received: from localhost ([::1]:38874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4itT-0008Vn-IV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Aug 2020 06:49:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44996) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4isw-0008VE-Qn for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2020 06:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4isw-0007El-HA for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2020 06:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k4isw-00068g-Df for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2020 06:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Aug 2020 10:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34657 X-GNU-PR-Package: emacs Original-Received: via spool by 34657-submit@debbugs.gnu.org id=B34657.159697011223561 (code B ref 34657); Sun, 09 Aug 2020 10:49:02 +0000 Original-Received: (at 34657) by debbugs.gnu.org; 9 Aug 2020 10:48:32 +0000 Original-Received: from localhost ([127.0.0.1]:60073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4isS-00067x-IQ for submit@debbugs.gnu.org; Sun, 09 Aug 2020 06:48:32 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:34546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4isR-00067h-IS for 34657@debbugs.gnu.org; Sun, 09 Aug 2020 06:48:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=b56BXXXX99rIY7HYKiU+0LZVWHQ8p2qJQZ7NcAO33Mw=; b=HpSAETuZu7HlnTmJ6oy2h8B6aT qBJ7Jg6wfBFBc1wVcwch+W+B7dn9AnfKR6jwy4iHbjiDD49TdJFF3iZ/JYwh0eAL61FXg78/6oyyk rtofwWksNi3ND7/X+cZeR2TjPxTo8oHJ6izcLppqNz63fBf/Bfl212HwKwyOU+mBHS/I=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4isD-0000mb-IN; Sun, 09 Aug 2020 12:48:25 +0200 In-Reply-To: <87lfitesdn.fsf@gmail.com> (Mingde Zeng's message of "Tue, 04 Aug 2020 22:30:44 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184395 Archived-At: (Note that I've moved this from emacs-devel to the bug report.) "Mingde (Matthew) Zeng" writes: > * lisp/erc/erc.el (erc-generate-new-buffer-name): since `target' is > always non-nil, buffer-name is non-nil, erc-reuse-buffers is t, it > will always use the first candidate, resulting in behavior 1. Is this correct, though? Otherwise I think the patch looks OK, but there's unfortunately been further changes to these functions, and your patch no longer applies. Can you re-spin the patch? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no