From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#16542: 24.3.50; When finding a file via a bookmark, that file is not part of file-name-history Date: Tue, 25 Aug 2020 12:57:03 +0200 Message-ID: <87k0xnat8g.fsf@gnus.org> References: <87lhy5kqa9.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3308"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 16542@debbugs.gnu.org To: Bastien Guerry Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 25 12:58:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAWeY-0000m5-PD for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Aug 2020 12:58:10 +0200 Original-Received: from localhost ([::1]:59026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAWeX-0007d5-Lu for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Aug 2020 06:58:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAWeP-0007aL-VM for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2020 06:58:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48929) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAWeP-0002N4-LW for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2020 06:58:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kAWeP-0004zF-L5 for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2020 06:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Aug 2020 10:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16542 X-GNU-PR-Package: emacs Original-Received: via spool by 16542-submit@debbugs.gnu.org id=B16542.159835303719098 (code B ref 16542); Tue, 25 Aug 2020 10:58:01 +0000 Original-Received: (at 16542) by debbugs.gnu.org; 25 Aug 2020 10:57:17 +0000 Original-Received: from localhost ([127.0.0.1]:60472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAWdh-0004xy-5I for submit@debbugs.gnu.org; Tue, 25 Aug 2020 06:57:17 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:40126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAWdf-0004xi-H3 for 16542@debbugs.gnu.org; Tue, 25 Aug 2020 06:57:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eKXPcpAaKH0/B6Jm+4/fLlf/C4t2nJYjgZCG9WswPIw=; b=j8DWQ4IoOFk+UjNdgRGKj8O9pm NFYOjquwmsN8DBlkzk4tOJ66HWTsZogKgVxWSxKlfA/vzU+ghiOT3qBp27XwPpKiVzd6ssIEp6WFS V/gZm0YlcH7asZtQmatO5S2hE4mVjnhgNp2NuhB5poMl9Mz/30Ru8WTvXtC/cx8HKFJw=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAWdU-0004eI-Gx; Tue, 25 Aug 2020 12:57:09 +0200 X-Now-Playing: Coil's _The Sound Of Musick_: "Proto-Protection" In-Reply-To: <87lhy5kqa9.fsf@bzg.ath.cx> (Bastien Guerry's message of "Fri, 24 Jan 2014 22:45:18 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186260 Archived-At: Bastien Guerry writes: > The subject line says it all. > > This trivial patch fixes it. > > Comments welcome, > > diff --git a/lisp/bookmark.el b/lisp/bookmark.el > index 5307cad..52697c2 100644 > --- a/lisp/bookmark.el > +++ b/lisp/bookmark.el [...] > + (add-to-history 'file-name-history file) I think this would be very surprising -- finding other things in the minibuffer history than things I've typed in would be pretty odd. As suggested, having a separate list of all visited files would be nice, but the UX here would be pretty awkward. That's discussed in bug#12915, though, so I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no