From: Lars Ingebrigtsen <larsi@gnus.org>
To: Bastien Guerry <bzg@altern.org>
Cc: 16542@debbugs.gnu.org
Subject: bug#16542: 24.3.50; When finding a file via a bookmark, that file is not part of file-name-history
Date: Tue, 25 Aug 2020 12:57:03 +0200 [thread overview]
Message-ID: <87k0xnat8g.fsf@gnus.org> (raw)
In-Reply-To: <87lhy5kqa9.fsf@bzg.ath.cx> (Bastien Guerry's message of "Fri, 24 Jan 2014 22:45:18 +0100")
Bastien Guerry <bzg@altern.org> writes:
> The subject line says it all.
>
> This trivial patch fixes it.
>
> Comments welcome,
>
> diff --git a/lisp/bookmark.el b/lisp/bookmark.el
> index 5307cad..52697c2 100644
> --- a/lisp/bookmark.el
> +++ b/lisp/bookmark.el
[...]
> + (add-to-history 'file-name-history file)
I think this would be very surprising -- finding other things in the
minibuffer history than things I've typed in would be pretty odd.
As suggested, having a separate list of all visited files would be nice,
but the UX here would be pretty awkward. That's discussed in bug#12915,
though, so I'm closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-08-25 10:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 21:45 bug#16542: 24.3.50; When finding a file via a bookmark, that file is not part of file-name-history Bastien Guerry
2014-01-25 8:19 ` Dani Moncayo
2014-01-25 8:42 ` Drew Adams
2014-01-27 11:29 ` Bastien
2014-01-27 15:11 ` Drew Adams
2014-01-27 15:26 ` Bastien
2014-01-27 17:31 ` Drew Adams
2014-01-28 7:28 ` Juri Linkov
2014-01-28 13:28 ` Stefan Monnier
2014-01-29 9:10 ` Juri Linkov
2014-01-29 10:43 ` Bastien
2014-01-29 13:58 ` Stefan Monnier
2014-01-28 16:20 ` Drew Adams
2020-08-25 10:57 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0xnat8g.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=16542@debbugs.gnu.org \
--cc=bzg@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.