From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.devel Subject: Re: toggle-light-dark-mode Date: Wed, 16 Sep 2020 23:14:09 +0300 Message-ID: <87k0wtfpim.fsf@protesilaos.com> References: <20200910102000.2t6tsju745xutg7u@Ergus> <20200910110832.ko66gqnqo4l664d6@Ergus> <20200911134225.zhnlq7cdhmu2iraj@Ergus> <20200911221435.go7b5kz2zcvxp2ft@Ergus> <20200912153723.ymnq3i5pugqf7lsy@Ergus> <20200912194652.nrcx2fjg7n4j54ns@Ergus> <87blia32b7.fsf@gmail.com> <871rj30vzq.fsf@gmail.com> <87d02mop87.fsf@mail.linkov.net> <87tuvyztq5.fsf@gmail.com> <87imce0zbr.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11160"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Caio Henrique , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 16 22:15:38 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIdq6-0002eI-7X for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Sep 2020 22:15:38 +0200 Original-Received: from localhost ([::1]:57992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIdq0-0000Tu-CN for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Sep 2020 16:15:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIdoq-0008Mc-8a for emacs-devel@gnu.org; Wed, 16 Sep 2020 16:14:20 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:49177) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIdoo-0007N2-7j for emacs-devel@gnu.org; Wed, 16 Sep 2020 16:14:19 -0400 X-Originating-IP: 213.207.159.49 Original-Received: from kronos (unknown [213.207.159.49]) (Authenticated sender: public@protesilaos.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 8FD08240002; Wed, 16 Sep 2020 20:14:12 +0000 (UTC) In-Reply-To: <87imce0zbr.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 16 Sep 2020 22:31:20 +0300") Received-SPF: none client-ip=217.70.183.193; envelope-from=public@protesilaos.com; helo=relay1-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/16 16:14:13 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255929 Archived-At: Juri Linkov [2020-09-16, 22:31 +0300]: >> Maybe this could also be an optional alternative behavior that you can >> enable with a boolean variable? toggle-light-dark-theme-use-reverse-video >> >> I like your suggestions and I can see that they appeal to other users, >> but personally I also wouldn't use reverse video (I like using >> kaolin-galaxy as my dark theme and modus-operandi for my light theme). >> >> Or we could also do the inverse: use the behavior of your code by >> default and make mine optional. :) > > Actually my point was that the default Emacs faces support both modes: > dark and light, so you can use the same default theme in different modes, > just by toggling frame-background-mode. This is implemented by using > '(background dark)' and '(background light)' in defface definitions. > > I wonder why other themes don't support both modes? For example, why there > is separate light tango-theme and tango-dark-theme, but not one tango-theme > supporting dark and light modes? And why separate light modus-operandi-theme > and dark modus-vivendi-theme, but not one modus-theme with both modes? Indeed, defface already provides the means to account for different display specs. Concerning the Modus themes' question, I simply did not know any better ~1 year ago when I started the project. The tango themes where my point of reference. Also, and if my memory serves me well, the command customize-create-theme did not account for light/dark variants. Going forward, it may be preferable to follow your suggestion. -- Protesilaos Stavrou protesilaos.com