From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43622: 28.0.50; [CLEANUP][PATCH] cperl-mode: Eliminate dead code Date: Sat, 26 Sep 2020 15:53:14 +0200 Message-ID: <87k0wglk51.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33077"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43622@debbugs.gnu.org To: Harald =?UTF-8?Q?J=C3=B6rg?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 26 15:54:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMAeT-0008UL-0o for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Sep 2020 15:54:13 +0200 Original-Received: from localhost ([::1]:38388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMAeS-0002Ag-0e for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Sep 2020 09:54:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMAeI-0002AX-M9 for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2020 09:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34606) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kMAeI-0003xv-BU for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2020 09:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kMAeI-0004Ot-8p for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2020 09:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Sep 2020 13:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43622 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43622-submit@debbugs.gnu.org id=B43622.160112840916841 (code B ref 43622); Sat, 26 Sep 2020 13:54:02 +0000 Original-Received: (at 43622) by debbugs.gnu.org; 26 Sep 2020 13:53:29 +0000 Original-Received: from localhost ([127.0.0.1]:46145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMAdl-0004NZ-8V for submit@debbugs.gnu.org; Sat, 26 Sep 2020 09:53:29 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:52282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMAdj-0004NJ-CB for 43622@debbugs.gnu.org; Sat, 26 Sep 2020 09:53:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=v0bKZ657jvP77yyMKkAtF21339znzqiLXU9zaTDK71A=; b=p4kCTGJlKlfBYbTuWJnV66wTJ8 04O2TtFZJ2un3CqQ+95Hj58g4vMsCaymodVgoZPPqgKlxlpNetXmtwe0ea0ahfZOahooVmx4HbmSH +u5Z7foDWmv8Md7EnjRFinnze1nb6k03DU1PkCGaO9HZiMFEFo2zDnS0PyqEHdkIq6bE=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMAdX-0007vG-OQ; Sat, 26 Sep 2020 15:53:20 +0200 X-Now-Playing: Jane Siberry's _The Walking_: "The Bird In The Gravel" In-Reply-To: ("Harald =?UTF-8?Q?J=C3=B6rg?="'s message of "Sat, 26 Sep 2020 02:35:15 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189026 Archived-At: Harald J=C3=B6rg writes: > As recently discussed on the emacs-devel list, I'd like to eradicate > conditional code from cperl-mode where the conditionals evaluate to nil. > > This is a rather large part of the cleanup, related to all that stuff > which has changed in the last years with regard to font-lock-mode and > cperl-mode's homegrown fontification based on features which are no > longer available. > > I tested Perl code on my repositories (twiki.org code and > https://github.com/act-psgi/Act), written by different authors in > different styles, and could not find any change in fontification. Looks good, so I've applied it to Emacs 28 with one change: In end of data: progmodes/cperl-mode.el:8525:1: Warning: the function `cperl-init-faces-wea= k' is not known to be defined. This function was removed, but the call wasn't, so I removed it (and changed the surrounding code slightly). If you could check that I didn't mess up that bit, that'd be nice. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no