Folding headings which contain only blank lines

Folding headings which contain only blank lines

[Dmitrii Korobeinikov]

Hi!

When everything is folded (e.g. on startup), ellipses show after every
heading which has anything in it at all. This is true as well for the
headings containing only one or more blank lines. And while you can
unfold such lines, you can't fold them back unless you use Shift-Tab.
This appears to be inconsistent. Shouldn't it be possible to tab fold
such headings too?

Best,
DK

Re: Folding headings which contain only blank lines

[Bastien]

Hi Dmitrii,

Dmitrii Korobeinikov <dim1212k@gmail.com> writes:

> When everything is folded (e.g. on startup), ellipses show after every
> heading which has anything in it at all. This is true as well for the
> headings containing only one or more blank lines. And while you can
> unfold such lines, you can't fold them back unless you use Shift-Tab.
> This appears to be inconsistent. Shouldn't it be possible to tab fold
> such headings too?

this should be fixed now (in ee3c3b554), thanks for reporting this.

-- 
 Bastien

Re: Folding headings which contain only blank lines

[Mikhail Skorzhisnkii]

Hi,

Patch ee3c3b554799c9f0fbe387848cd9eec7e9ab9d95 breaks unfolding 
when
org-cycle-separator-lines set to -1.

How to reproduce:
  1. Set org-cycle-separator-lines to -1;
  2. Try to fold and then unfold "Test" in the following file:
#+begin_example
,* Test 1
,** Test 2




,* Test 3
#+end_example

Unfolding will not unfold Test1 with 
ee3c3b554799c9f0fbe387848cd9eec7e9ab9d95 applied. Reverting this 
patch makes it working back. Is there are any other way to fix 
this? Or may be this can be made as a customisation option?

Bastien <bzg@gnu.org> writes:

> Hi Dmitrii,
>
> Dmitrii Korobeinikov <dim1212k@gmail.com> writes:
>
>> When everything is folded (e.g. on startup), ellipses show 
>> after every
>> heading which has anything in it at all. This is true as well 
>> for the
>> headings containing only one or more blank lines. And while you 
>> can
>> unfold such lines, you can't fold them back unless you use 
>> Shift-Tab.
>> This appears to be inconsistent. Shouldn't it be possible to 
>> tab fold
>> such headings too?
>
> this should be fixed now (in ee3c3b554), thanks for reporting 
> this.


Kind regards,
  Mikhail Skorzhinskii

Re: Folding headings which contain only blank lines

[Kyle Meyer]

Mikhail Skorzhisnkii writes:

> Hi,
>
> Patch ee3c3b554799c9f0fbe387848cd9eec7e9ab9d95 breaks unfolding 
> when
> org-cycle-separator-lines set to -1.
[...]
> Unfolding will not unfold Test1 with 
> ee3c3b554799c9f0fbe387848cd9eec7e9ab9d95 applied. Reverting this 
> patch makes it working back. Is there are any other way to fix 
> this? Or may be this can be made as a customisation option?

A fix is certainly in order, and there is some discussion at
https://orgmode.org/list/CAJj=8EFJXFu9ZQ11cO24AAu=1jykW2Zr+=R4FLuKG=bLjfUe+g@mail.gmail.com/T/#u

In that thread (<https://orgmode.org/list/87tuviqyi4.fsf@kyleam.com>), I
was trying to find an example of the issue fixed by ee3c3b55.  Dmitrii,
did ee3c3b55 solve the issue on you reported?

Re: Folding headings which contain only blank lines

[Dmitrii Korobeinikov]

> was trying to find an example of the issue fixed by ee3c3b55.  Dmitrii,
> did ee3c3b55 solve the issue on you reported?

Hi, Kyle, I haven't checked it, but since several people reported that
it wasn't working for them, I decided to forego the trouble of
installing it myself (I am using the stock org mode).

Re: Folding headings which contain only blank lines

[Kyle Meyer]

Dmitrii Korobeinikov writes:

>> was trying to find an example of the issue fixed by ee3c3b55.  Dmitrii,
>> did ee3c3b55 solve the issue on you reported?
>
> Hi, Kyle, I haven't checked it, but since several people reported that
> it wasn't working for them, I decided to forego the trouble of
> installing it myself (I am using the stock org mode).

Okay, thanks.  Any chance you could provide a minimal reproducer for
your original issue so I can check on my end?  As I mentioned in the
referenced thread [*], I haven't been able to figure out which case, if
any, was resolved by ee3c3b55.

[*] https://orgmode.org/list/87tuviqyi4.fsf@kyleam.com

Re: Folding headings which contain only blank lines

[Dmitrii Korobeinikov]

> Any chance you could provide a minimal reproducer for
> your original issue so I can check on my end?

Certainly, save this:

---cut----------------------------------------
* empty heading



* another one



---cut end-------------------------------

Now, when opening this file, you will see:

---cut----------------------------------------
* empty heading...

* another one



---cut end-------------------------------

(use shift-tab if fold on startup is disabled)

Problem is: after unfolding "empty heading" you can't fold it back
(barring the use of org-shifttab). One comorbid issue here, btw, is
that "another one" isn't folded initially at all...

сб, 24 окт. 2020 г. в 08:43, Kyle Meyer <kyle@kyleam.com>:
>
> Dmitrii Korobeinikov writes:
>
> >> was trying to find an example of the issue fixed by ee3c3b55.  Dmitrii,
> >> did ee3c3b55 solve the issue on you reported?
> >
> > Hi, Kyle, I haven't checked it, but since several people reported that
> > it wasn't working for them, I decided to forego the trouble of
> > installing it myself (I am using the stock org mode).
>
> Okay, thanks.  Any chance you could provide a minimal reproducer for
> your original issue so I can check on my end?  As I mentioned in the
> referenced thread [*], I haven't been able to figure out which case, if
> any, was resolved by ee3c3b55.
>
> [*] https://orgmode.org/list/87tuviqyi4.fsf@kyleam.com

Re: Folding headings which contain only blank lines

[Kyle Meyer]

Dmitrii Korobeinikov writes:

>> Any chance you could provide a minimal reproducer for
>> your original issue so I can check on my end?
>
> Certainly, save this:
>
> ---cut----------------------------------------
> * empty heading
>
>
>
> * another one
>
>
>
> ---cut end-------------------------------
[...]
> Problem is: after unfolding "empty heading" you can't fold it back
> (barring the use of org-shifttab). One comorbid issue here, btw, is
> that "another one" isn't folded initially at all...

Thanks.  Okay, that matches closely the test case I tried in
<https://orgmode.org/list/87tuviqyi4.fsf@kyleam.com>.  As was the case
there, I can trigger the issue you reported both before and after
ee3c3b554.

So, given ee3c3b554 doesn't appear to resolve the initial issue and
introduces its own, I'm in favor of reverting ee3c3b554.  I'll plan to
do so in a day or two if I don't hear objections.

Re: Folding headings which contain only blank lines

[Kyle Meyer]

Kyle Meyer writes:

> So, given ee3c3b554 doesn't appear to resolve the initial issue and
> introduces its own, I'm in favor of reverting ee3c3b554.  I'll plan to
> do so in a day or two if I don't hear objections.

Done in e8070d71a.