From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master aea9365 3/3: * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type. Date: Fri, 06 Nov 2020 21:33:33 +0000 Message-ID: <87k0uy5fwy.fsf@tcd.ie> References: <20201106130101.11980.32709@vcs0.savannah.gnu.org> <20201106130103.DF32C20CAE@vcs0.savannah.gnu.org> <871rh676cx.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39723"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 06 22:34:37 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kb9NV-000ABc-2F for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 22:34:37 +0100 Original-Received: from localhost ([::1]:48396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kb9NU-0005St-41 for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 16:34:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kb9Mb-0004q3-79 for emacs-devel@gnu.org; Fri, 06 Nov 2020 16:33:41 -0500 Original-Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:33922) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kb9MY-0002pW-QK for emacs-devel@gnu.org; Fri, 06 Nov 2020 16:33:40 -0500 Original-Received: by mail-wm1-x331.google.com with SMTP id 23so1751265wmg.1 for ; Fri, 06 Nov 2020 13:33:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=nEx2nbtkXF1G0SdVgDH2m8UtSsGlqhNp1IXp3Db8Kos=; b=JEacsr0TtiETIJjzheiC50ngS8qouPBhUsWQwhfwD0zS7d85NhPriWCPaIygzza1oG HrbD0/V1M1Ls9wkYjf8B6KurEsWcJsadPn/zTHaxZONjwPl9fwBCh1RYH2MTznbfXKf5 rbSCPfhNpOBZIIclaQff0BwkqnxkZ64bHkqEenMG/4qJGnkaDVvqUAL1JLQfxliFDkc2 X5O27PRGCMtlOcRQHEipgUUFgR3Rr+DlusI3HWBHRmFkj/nI/3TDjiM4QqspzHjK7Lxg PO1xXRaQlYcCiBJKKoctCZaINnBsZ0cy4v2ydwqxge+VrJZbWNwR0f1nwfld2aJ9kudF lbBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=nEx2nbtkXF1G0SdVgDH2m8UtSsGlqhNp1IXp3Db8Kos=; b=QPvQneafCwQDn6N17RkDBpK2OTwihgVSJpCr5gLMdqCiGy0qjiMW2b4sILjhoGsjhF I0LsC5+fbBdF9FlbitpUyEPyMVgrVATPRDEPoTRLqaUQdwcD0Qv34GuYJlSTpD1ytYQT EGWzd0sUt7zQnuiN5tskqiuHkG6L04tbxyBDNA3ejIRM/N0fX61u60mmoJe5jiT2y2IT s6OosuQ31CHpBQkRhhgRgbou5BZOwomDnLGiw+3kmPhfkVcClgM3SURM2m02qmgltC3A 0hNoiW2V+BPCU/1ZBKG/b+JpPpxUT/ILI7vm/+Gef/No2yV7lsTWthMiLYEhqQm4AKW2 MvUw== X-Gm-Message-State: AOAM5323fHRC1AhatD4sa79pC4j5+Ss+JGwFmUtvL8FBCdThYgOLK4Sl 1LE4CGTqSedBfVUKnT1+k2UrlA== X-Google-Smtp-Source: ABdhPJxSw43Q6+N3CeGPUzvNu2Jc04wsYL4Ptd1EV9HgThr4XMjSNnZbcZcsX644WkS/N6AAkZzjLg== X-Received: by 2002:a1c:2203:: with SMTP id i3mr1626988wmi.144.1604698415237; Fri, 06 Nov 2020 13:33:35 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id z2sm4000301wmf.45.2020.11.06.13.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:33:34 -0800 (PST) In-Reply-To: <871rh676cx.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 06 Nov 2020 09:17:02 -0800") Received-SPF: none client-ip=2a00:1450:4864:20::331; envelope-from=contovob@tcd.ie; helo=mail-wm1-x331.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258859 Archived-At: Eric Abrahamsen writes: > Mattias Engdeg=C3=A5rd writes: > >> branch: master >> commit aea936562b033899f0b7160cc492bbea1006863b >> Author: Mattias Engdeg=C3=A5rd >> Commit: Mattias Engdeg=C3=A5rd >> >> * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type. >>=20=20=20=20=20 >> A more precise type is desirable but at it is now correct ('list' is= not). >> --- >> lisp/gnus/gnus-search.el | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lisp/gnus/gnus-search.el b/lisp/gnus/gnus-search.el >> index 15d96e3..7ee7c53 100644 >> --- a/lisp/gnus/gnus-search.el >> +++ b/lisp/gnus/gnus-search.el >> @@ -410,7 +410,7 @@ returned by `completion-at-point-functions'. That u= sually means >> a list of strings, a hash table, or an alist." >> :group 'gnus-search >> :version "28.1" >> - :type 'list) >> + :type '(repeat sexp)) > > Doesn't this type demand a list of lists? It could also be a list of > hashtables, or functions, or a mix of alist/list/function/hashtable... A sexp in this context is "any Lisp object that can be printed and read back". That covers most completion table types, right? AFAICT the only type more general than that is restricted-sexp. --=20 Basil