From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id x6wdOy232V9jKgAA0tVLHw (envelope-from ) for ; Wed, 16 Dec 2020 07:28:45 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yPiPNi232V+FTwAAB5/wlQ (envelope-from ) for ; Wed, 16 Dec 2020 07:28:45 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6E486940148 for ; Wed, 16 Dec 2020 07:28:45 +0000 (UTC) Received: from localhost ([::1]:38012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpREo-0003F0-Ro for larch@yhetil.org; Wed, 16 Dec 2020 02:28:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpRE0-0003Ed-5R for emacs-orgmode@gnu.org; Wed, 16 Dec 2020 02:27:52 -0500 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]:36983) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpRDy-0007Zl-FF; Wed, 16 Dec 2020 02:27:51 -0500 Received: by mail-pf1-x42e.google.com with SMTP id 11so16041777pfu.4; Tue, 15 Dec 2020 23:27:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=yCsT8HkafNLObVT4HJE9oaY0qXIlAdlHXFL2HLfVhzM=; b=p0bOMr6VU5CjycOX8VZq4GNO+aT89f8CBaBKnIFZNZCDDg31+plfNHgIbDvR2hA9Hp cDvoMJjAl1nfAUsZvn/q0q6ovdh70tsdJJzGyQBZyN5kIAol0mbTIdyI5WsaepMhGB9C usmWyVp49M6FOhmp4z9pj+gIZe0ndlUiHtbCcXS9FbIGWYZegI7pIwUhljYFdPKISDy8 itFawlh2Bf9BqHbHnorpQ3i4Q9vcv4M0aUYx38fAjB9cgAoBzCGidFwUgSRxc/tTv+Rj Ez714q0/2cuRv/EIFHoW/BSK1/t2o74ofRgBw2/iDs/a4BR4wQsYG64G0Uh3uAl1/ePM Knrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=yCsT8HkafNLObVT4HJE9oaY0qXIlAdlHXFL2HLfVhzM=; b=mcO6kpHBgp6973y3e6ftJa2LkX1ylrVMKVIRbNJ51L+qj8Mm/AoBHoEP9armc9EDsH gxWZRGzbGhR7dqcobUxPlpaJJCBu4hCrvp76cfa9lo9dtF4B9JOHiwNrvtLlZu5kvncf DtsVnnqrfdSEPvOt9lpYKfmMVcBWG7NxeFw2vD1KZr5W/Xz9rVo8gcwfWKlsQ3aoN9se QPg25O50mejTymZY1a8n1gIzaORhBLK/BhGPEadHadxeXawmT/m0lOqbZ6+6/viPvrsW eCRCvyMro6iBplEcwb5PnI65mdP8UCdUewnY9+d2C8/24PLUX1ap58/8sq4ENr1fd2pv dnsw== X-Gm-Message-State: AOAM53172Y0bjtkU6DqsKCKQwszKilvLeWKVnrDjk/PDGL/2fySClcYQ LGfYPajI+JTgu+Zp+Zt9kfWPpvXpT28= X-Google-Smtp-Source: ABdhPJypSn31pfEdCwH24+3JIadnHXOXpZwg+xCY2wzLObzNHgZBNX+EgMRpO8+oB4dzPAFsEOzzqQ== X-Received: by 2002:a63:181b:: with SMTP id y27mr31794205pgl.408.1608103668611; Tue, 15 Dec 2020 23:27:48 -0800 (PST) Received: from localhost (180-150-91-8.b4965b.per.nbn.aussiebb.net. [180.150.91.8]) by smtp.gmail.com with ESMTPSA id y6sm1280206pfn.145.2020.12.15.23.27.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Dec 2020 23:27:48 -0800 (PST) References: <87pn6kfr19.fsf@gmail.com> <87v9gcz9ge.fsf@wi.uni-muenster.de> <87lfh8fkj1.fsf@gmail.com> <87zh5n1p3s.fsf@wi.uni-muenster.de> <87tuvl3fyc.fsf@gmail.com> <878scvs0z7.fsf@wi.uni-muenster.de> <87wo0fktjs.fsf@gmail.com> <874knjrtg9.fsf@wi.uni-muenster.de> <87tuvjkqzl.fsf@gmail.com> <87sgb28gd8.fsf@wi.uni-muenster.de> <87blexel9f.fsf@gmail.com> <87im94ordh.fsf@gnu.org> <87tusolntx.fsf@wi.uni-muenster.de> <873607uw3y.fsf@gmail.com> <87im928ck3.fsf@wi.uni-muenster.de> User-agent: mu4e 1.4.13; emacs 27.1 From: TEC To: Jens Lechtenboerger Subject: Re: [PATCH] Enhance org-html--build-meta-info Date: Wed, 16 Dec 2020 15:22:53 +0800 In-reply-to: <87im928ck3.fsf@wi.uni-muenster.de> Message-ID: <87k0tidxcf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=tecosaur@gmail.com; helo=mail-pf1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastien , org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.01 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=p0bOMr6V; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 6E486940148 X-Spam-Score: -3.01 X-Migadu-Scanner: scn0.migadu.com X-TUID: QOf0yBr92jdU Jens Lechtenboerger writes: > I like this! :) >> Maybe it should be applied to the rest (in ~org-html--build-meta-info~)? >> I'm not sure. > > I=E2=80=99m not sure either. Maybe people expect their typed characters, > maybe not. This might call for a new variable. I'm tempted to leave the current behaviour as-is, and then we can introduce a new variable if we want later :) > I like the new variant much better. However, I still do not > understand why you pass the title into org-html-meta-tags-default > just to ignore it. The title is already dealt with elsewhere, isn=E2=80= =99t > it? For people who want to customise this to add metadata, the page title is something they're probably interested in. If so, I think it's work giving the title processed by org-html--build-meta-info as it's not so simple as (plist-get info :title). Worst case, the argument just sits there and is ignored :P > Some comments raise complaints by checkdoc (lines too long, no > sentence in fist line). (Actually, the file has more problems in > that regard.) Ooops, I thought I took care of that. Looks like I'll be taking another look... Would be nice my issues weren't one of dozens throughout the file, it makes it a bit harder to notice errors coming from /my/ section. > Many thanks for your continued work! Thanks for your testing and feedback! -- Timothy