From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45879: 28.0.50; [PATCH] missing defvar for keymap-name-history Date: Tue, 19 Jan 2021 07:09:02 +0100 Message-ID: <87k0s9o3up.fsf@gnus.org> References: <87r1mn6nw1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27794"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45879@debbugs.gnu.org To: "James N. V. Cash" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 19 07:10:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1kDf-00077d-O7 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jan 2021 07:10:23 +0100 Original-Received: from localhost ([::1]:55398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1kDe-0007m3-PG for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jan 2021 01:10:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1kDL-0007lb-7p for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 01:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37611) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1kDL-0002Qu-0s for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 01:10:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l1kDK-00019y-Q0 for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 01:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jan 2021 06:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45879 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45879-submit@debbugs.gnu.org id=B45879.16110365594380 (code B ref 45879); Tue, 19 Jan 2021 06:10:02 +0000 Original-Received: (at 45879) by debbugs.gnu.org; 19 Jan 2021 06:09:19 +0000 Original-Received: from localhost ([127.0.0.1]:49154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1kCd-00018a-AO for submit@debbugs.gnu.org; Tue, 19 Jan 2021 01:09:19 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:55098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1kCb-00018L-B1 for 45879@debbugs.gnu.org; Tue, 19 Jan 2021 01:09:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ilYF94IjmunYxEWRG2olKARs/jhjqlPppCkReq1rN8Y=; b=WW7fP/g3OBrUROoNXu79VQ1Pra tRwxRvk4r8f9PMd1YfkGV3HHnpunXv2PNXIu+9LrqiEAMTiETYWrpztc+9M8ICvMpVDEVlZziHrYl ZF5cPOIoVckWBnvWn0PUSIiO53G875n6GWskqzie71NEga15kSWGOEGJH4mrEQtj9KKg=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1kCN-0004F7-QJ; Tue, 19 Jan 2021 07:09:11 +0100 X-Now-Playing: Slick's _For Discos Only (2)_: "Space Bass (Special 12Inch Disco Mix)" In-Reply-To: <87r1mn6nw1.fsf@gmail.com> (James N. V. Cash's message of "Thu, 14 Jan 2021 19:32:14 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198129 Archived-At: "James N. V. Cash" writes: > It seems that the new describe-keymaps function in help-fns.el is > missing a defvar for keymap-name-history. This results in an error > when using, e.g. Helm as the completing-read function. > > The attached patch adds the defvar to help-fns.el. Thanks; applied to Emacs 28. As Drew pointed out, `completing-read' helpfully defines variables if they aren't already, but I think we should define them, because not doing so leads to the problems we see in Helm, for instance. This change was small enough to apply without assigning copyright to the FSF, but for future patches you want to submit, it might make sense to get the paperwork started now, so that subsequent patches can be applied speedily. Would you be willing to sign such paperwork? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no