From: Lars Ingebrigtsen <larsi@gnus.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 42425@debbugs.gnu.org, "João Távora" <joaotavora@gmail.com>
Subject: bug#42425: 26.3.50; Compilation warnings when compiling eldoc.el under Emacs 26.3
Date: Sat, 23 Jan 2021 19:31:27 +0100 [thread overview]
Message-ID: <87k0s3v728.fsf@gnus.org> (raw)
In-Reply-To: <CAArVCkQHc79w135332dCdvZx_RZJeooLQ38bbpoRsRX4ZEKEZg@mail.gmail.com> (Philipp Stephani's message of "Sat, 23 Jan 2021 18:35:07 +0100")
Philipp Stephani <p.stephani2@gmail.com> writes:
>> Doing so seems easy enough, but I'm not sure how high our ambitions are
>> for doing warning-free ELPA packages on older Emacs versions? (I've
>> added João to the CCs.)
>
> I think our ambitions should be quite high. (I personally think we
> should treat almost all compiler warnings as errors/bugs and fix them
> whenever realistically possible.)
Building Emacs has traditionally been watching a wall of warnings scroll
by. This has recently changed, but shows that "no warnings" isn't a
value held universally by the Emacs developers.
I think that the Emacs build should be warning free -- on our main,
current targets. Jumping through hoops to avoid warnings on older Emacs
versions normally isn't worth spending time on, in my opinion.
But we really have no policy here.
>> > 2. Probably eldoc should protect against newer Elisp functions being not
>> > yet available, as calling such functions will likely result in errors
>> > at runtime.
>>
>> Doesn't it do that? What functions is it using that's not available?
>
> At least the current master version looks fine, though the byte
> compiler isn't smart enough to detect that. The problematic uses are
> in eldoc--eval-expression-setup.
I'm not sure I follow you here -- are you saying that eldoc doesn't work
on Emacs 26 because of the usages in `eldoc--eval-expression-setup'?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-01-23 18:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 8:12 bug#42425: 26.3.50; Compilation warnings when compiling eldoc.el under Emacs 26.3 Philipp Stephani
2021-01-22 19:58 ` Lars Ingebrigtsen
2021-01-22 20:22 ` João Távora
2021-01-23 17:35 ` Philipp Stephani
2021-01-23 17:53 ` João Távora
2021-01-23 18:31 ` Lars Ingebrigtsen [this message]
2021-01-24 9:30 ` Philipp Stephani
2021-01-26 0:07 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0s3v728.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=42425@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.