From: Lars Ingebrigtsen <larsi@gnus.org>
To: emacs-devel@gnu.org
Subject: A faster derived-mode-p
Date: Sun, 14 Feb 2021 21:22:11 +0100 [thread overview]
Message-ID: <87k0ra9z7w.fsf@gnus.org> (raw)
There are only 11K commands in the Emacs tree, so I don't know whether
the current default completion predicate is going to turn out to be
problematically slow or not.
It basically calls `provided-mode-derived-p' for all annotated commands,
and this is a loop that chases mode parenthood back to its ultimate
ancestor.
It seems like this could done more efficiently by just resolving the
chain at `define-derived-mode' time. That is, in addition to putting
`derived-mode-parent', it could put `derived-mode-parents', too, where
it chases the chain upwards. Then we'd just have to look at a single
property list...
Does anybody see any disadvantages to doing it this way? (This would
speed up `derived-mode-p', which we use all over Emacs, in general.)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next reply other threads:[~2021-02-14 20:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 20:22 Lars Ingebrigtsen [this message]
2021-02-14 22:25 ` A faster derived-mode-p Dmitry Gutov
2021-02-14 22:45 ` Basil L. Contovounesios
2021-02-14 23:03 ` Óscar Fuentes
2021-02-15 2:34 ` Dmitry Gutov
2021-02-15 2:47 ` Lars Ingebrigtsen
2021-02-14 23:51 ` Stefan Monnier
2021-02-15 2:56 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0ra9z7w.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.