From: Lars Ingebrigtsen <larsi@gnus.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: Glenn Morris <rgm@gnu.org>, 46641@debbugs.gnu.org
Subject: bug#46641: process-tests assume network connection
Date: Sun, 21 Feb 2021 14:41:11 +0100 [thread overview]
Message-ID: <87k0r1k07c.fsf@gnus.org> (raw)
In-Reply-To: <871rd9smip.fsf@gmail.com> (Robert Pluim's message of "Sun, 21 Feb 2021 12:11:58 +0100")
Robert Pluim <rpluim@gmail.com> writes:
> Glenn> Some process-tests fail if the system has no network connection.
> Glenn> I don't know what the appropriate skip-unless condition to test for
> Glenn> network access is.
>
> Glenn> Ref: https://bugs.debian.org/982969
>
> So Debian deliberately cripple their test environment, run the network
> tests for an editor which can do network access, and we have to adapt
> our tests? I am not amused.
>
> I guess we could wrap them all in
>
> (skip-unless (dns-query "google.com"))
It'd be nice if Emacs did have a predicate for "is there any network
here?" But I don't know what that would look like. That is, there's a
difference between having a local network (i.e., 127.0.0.1), and being
on the Internet.
But if any of our tests require Emacs to be on a functioning internet
connection, they should indeed be guarded by something like the
`skip-unless' you propose.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-02-21 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 17:59 bug#46641: process-tests assume network connection Glenn Morris
2021-02-21 11:11 ` Robert Pluim
2021-02-21 13:41 ` Lars Ingebrigtsen [this message]
2021-02-21 14:40 ` Philipp
2021-02-21 16:19 ` Robert Pluim
2021-02-21 16:45 ` Robert Pluim
2021-02-21 18:32 ` Lars Ingebrigtsen
2021-02-22 14:49 ` Robert Pluim
2021-02-21 14:37 ` Philipp
2021-02-21 16:21 ` Robert Pluim
2021-02-21 19:40 ` Philipp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0r1k07c.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=46641@debbugs.gnu.org \
--cc=rgm@gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.