From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#45474: Icomplete exhibiting in recursive minibuffer when it =?UTF-8?Q?shouldn=E2=80=99t?= Date: Fri, 23 Apr 2021 00:57:56 +0300 Organization: LINKOV.NET Message-ID: <87k0oukn3n.fsf@mail.linkov.net> References: <3ed97a9c53e0a5d4fef8@heytings.org> <87fszrz21d.fsf@mail.linkov.net> <3ed97a9c530093aca93d@heytings.org> <7dee3f4235d331cab291@heytings.org> <87r1jatd34.fsf@mail.linkov.net> <7dee3f423551aaf318cb@heytings.org> <87im4kzlfm.fsf@mail.linkov.net> <1869622e16546eafd9df@heytings.org> <871rb6np5j.fsf@mail.linkov.net> <87lf9cepqw.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9284"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Gregory Heytings , Dario Gjorgjevski , 45474@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 23 00:11:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZhXa-00027j-CH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Apr 2021 00:11:18 +0200 Original-Received: from localhost ([::1]:57042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZhXZ-0000Hb-GH for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Apr 2021 18:11:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZhXK-0000HC-Nv for bug-gnu-emacs@gnu.org; Thu, 22 Apr 2021 18:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZhXK-00031v-Gf for bug-gnu-emacs@gnu.org; Thu, 22 Apr 2021 18:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lZhXK-0001Yc-Bn for bug-gnu-emacs@gnu.org; Thu, 22 Apr 2021 18:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Apr 2021 22:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45474 X-GNU-PR-Package: emacs Original-Received: via spool by 45474-submit@debbugs.gnu.org id=B45474.16191294025887 (code B ref 45474); Thu, 22 Apr 2021 22:11:02 +0000 Original-Received: (at 45474) by debbugs.gnu.org; 22 Apr 2021 22:10:02 +0000 Original-Received: from localhost ([127.0.0.1]:35746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZhWM-0001Wo-0F for submit@debbugs.gnu.org; Thu, 22 Apr 2021 18:10:02 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:40439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZhWH-0001W2-Ua for 45474@debbugs.gnu.org; Thu, 22 Apr 2021 18:09:58 -0400 X-Originating-IP: 91.129.102.166 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 86BA160003; Thu, 22 Apr 2021 22:09:50 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Thu, 22 Apr 2021 10:13:22 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204722 Archived-At: > I'm more and more thinking that we should really bite the bullet and go > for a "really buffer-local" setup, such as in the patch below. > I'd be surprised if it doesn't introduce backward incompatibilities, but > at least it's "The Right Thing" to do. I've tested your new patch with tests that Gregory posted in an earlier message that cover all cases of nested completion and non-completion minibuffers: M-: C-x C-f C-x C-f M-: C-x C-f C-x 8 RET M-: C-x f with (icomplete-mode 1) (setq icomplete-show-matches-on-no-input t enable-recursive-minibuffers t) and everything works fine without problems. Of course, this doesn't mean that some corner cases still exist. But I don't know a better way to find out than to install it and wait for bug reports.