From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#48073: 27.2; [Eglot] Don't bind `completion-styles' buffer locally? Date: Wed, 28 Apr 2021 09:00:19 +0200 Message-ID: <87k0omvqpo.fsf@gmail.com> References: <871rav4jri.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19801"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 48073@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 28 09:01:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbeCL-00051g-OX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 09:01:25 +0200 Original-Received: from localhost ([::1]:49652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbeCK-00016P-Qk for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 03:01:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40196) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbeBy-00015E-Ut for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 03:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40032) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbeBy-00047w-J2 for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 03:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lbeBy-0006Ch-FD for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 03:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Apr 2021 07:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48073 X-GNU-PR-Package: emacs Original-Received: via spool by 48073-submit@debbugs.gnu.org id=B48073.161959323223802 (code B ref 48073); Wed, 28 Apr 2021 07:01:02 +0000 Original-Received: (at 48073) by debbugs.gnu.org; 28 Apr 2021 07:00:32 +0000 Original-Received: from localhost ([127.0.0.1]:51578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbeBT-0006Bq-PC for submit@debbugs.gnu.org; Wed, 28 Apr 2021 03:00:31 -0400 Original-Received: from mail-ed1-f50.google.com ([209.85.208.50]:46072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbeBQ-0006Bc-1S for 48073@debbugs.gnu.org; Wed, 28 Apr 2021 03:00:30 -0400 Original-Received: by mail-ed1-f50.google.com with SMTP id d14so9042299edc.12 for <48073@debbugs.gnu.org>; Wed, 28 Apr 2021 00:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4PShf/OWiiUjyyTbvuEOwFeV8r88pXsUbywH2NhDkDc=; b=HtIKfbKcfQpVMEmvn7tJu7Umd56usgc4XVvZV5WT9wDD3cMLFwYwl+ZfDGf79pWk4E SiQiz6RoEm8r9RkwISyjzVkDmRNmjq9uTbsEFwszbRDrfAIRPIy6vYKDc0NfzBT2zZqD JYF79kABbCnhXzxa7ia4cV1E4wgM3WiUcfpNfXqZekuRgcURJ6ejIywDKqsoTAoZujw0 Idc+9bsjrmocs8FAJquEXkSY7rSFMyPcMJAsXApddAxgxm7ZCdmoErZsos6ZHDsw/See XYmMaQa3NFoo6gVAf4rU616JuO2Dd3fdCzq0Hg5h+qZzj7c2hrsIaWuAkpr1f4q+ppHJ 4I5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=4PShf/OWiiUjyyTbvuEOwFeV8r88pXsUbywH2NhDkDc=; b=KbDlCSDvE3W+EdLB8lS32ZZZhKCAHLXpgBPlwc0YDL4YOYVIaxaJIDwyq5LBZVl7yf PzPiSwm1JoUBy9v6LGVZ1/oonl/NxXALCuC86eCItk6MFzjtjjOBWi3f2/kEOMaJsoec ZQsO1p48WQ0abL9PPh4jGRRvb0EF3f4l8lZ7QoqB1GVeR3oz01uSt22T+yOJt/O3CgJy ZjaeXCYHl/17hIBYy6Hz28snxmQkWrSXTd1PtN2GrEEvhkTNgvd2/52hm8C245COZYAh tvEVX0DH3Dh1GdfN34VpwK4B2dUhiBsyNLmYI8M+c5PhBT0S5qA4StLaC5wBzNuvd8SS FYgw== X-Gm-Message-State: AOAM532c++ACNe/Jr0xjFNjzvQwrUuRZdZsGZNMcFKKSuUFTIX5pDsUi B9T8hHRf9HAIQP7xTrNaIfRduHtAedRA6w== X-Google-Smtp-Source: ABdhPJwmrSllTrIjrxh0zf8ErmdNL15S6UqYjl2IoJEtkT5GInuRV1xuhaHFpX5VdTiK1jynbxcrKw== X-Received: by 2002:a50:eb89:: with SMTP id y9mr8989354edr.172.1619593221833; Wed, 28 Apr 2021 00:00:21 -0700 (PDT) Original-Received: from ars3 ([2a02:908:2211:8540::68a]) by smtp.gmail.com with ESMTPSA id bu26sm1306429ejb.30.2021.04.28.00.00.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 00:00:21 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Tue, 27 Apr 2021 19:13:42 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205082 Archived-At: --=-=-= Content-Type: text/plain Here is a patch setting `completion-category-defaults'. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Add-a-completion-category-defaults-entry.patch >From e9d877c9c7203ce999a935cdbc36c619255cf63c Mon Sep 17 00:00:00 2001 From: Augusto Stoffel Date: Wed, 28 Apr 2021 08:50:10 +0200 Subject: [PATCH] Add a completion-category-defaults entry Setting `completion-styles' buffer locally is harder to customize and can break some completion UIs * eglot.el: Add a completion-category-defaults entry, if applicable. * eglot.el (eglot--managed-mode): Don't set `completion-styles' buffer-locally. * eglot.el (eglot-completion-at-point): Add style metadata to completion table. --- eglot.el | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/eglot.el b/eglot.el index 3348054..122a76b 100644 --- a/eglot.el +++ b/eglot.el @@ -222,6 +222,10 @@ let the buffer grow forever." :type '(choice (const :tag "Don't show confirmation prompt" nil) (symbol :tag "Show confirmation prompt" 'confirm))) +;; Customizable via `completion-category-overrides'. +(when (assoc 'flex completion-styles-alist) + (add-to-list 'completion-category-defaults '(eglot (styles flex basic)))) + ;;; Constants ;;; @@ -1421,8 +1425,6 @@ Use `eglot-managed-p' to determine if current buffer is managed.") (eglot--setq-saving flymake-diagnostic-functions '(eglot-flymake-backend)) (eglot--setq-saving company-backends '(company-capf)) (eglot--setq-saving company-tooltip-align-annotations t) - (when (assoc 'flex completion-styles-alist) - (eglot--setq-saving completion-styles '(flex basic))) (unless (eglot--stay-out-of-p 'imenu) (add-function :before-until (local 'imenu-create-index-function) #'eglot-imenu)) @@ -2166,7 +2168,8 @@ is not active." (get-text-property 0 'eglot--lsp-item c) :sortText) ""))))) - (metadata `(metadata . ((display-sort-function . ,sort-completions)))) + (metadata `(metadata (category . eglot) + (display-sort-function . ,sort-completions))) resp items (cached-proxies :none) (proxies (lambda () -- 2.30.2 --=-=-=--