all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 48298@debbugs.gnu.org, lewwadoo@gmail.com
Subject: bug#48298: Invalid time specification: encode-time((0 30 11 1 1 0 nil -1 nil))
Date: Sun, 09 May 2021 11:03:59 +0100	[thread overview]
Message-ID: <87k0o8441c.fsf@tcd.ie> (raw)
In-Reply-To: <87zgx4nsjd.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 09 May 2021 11:52:06 +0200")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>>    (unless (decoded-time-year time)
>> -    (setf (decoded-time-year time) 0))
>> +    (setf (decoded-time-year time) 1970))
>
> Sure; that makes as much sense as anything, but the doc string should
> perhaps mention it.

It already does:

  The default value is based on January 1st, 1970 at midnight.

Can it be clarified further?

> (All the other defaults are as zero-ish as possible, and 1970 is used
> here only because of technical limitations.)

Is it worth mentioning in the docstring that 1970 is chosen to guarantee
portability, similar to the note in encode-time's docstring?

Thanks,

-- 
Basil





  reply	other threads:[~2021-05-09 10:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-08 16:55 bug#48298: Invalid time specification: encode-time((0 30 11 1 1 0 nil -1 nil)) Евгений Михайлов
2021-05-08 22:37 ` Basil L. Contovounesios
2021-05-09  7:07   ` Eli Zaretskii
2021-05-09  6:46 ` Eli Zaretskii
2021-05-09  8:19   ` Basil L. Contovounesios
2021-05-09  8:27     ` Eli Zaretskii
2021-05-09  8:54       ` Basil L. Contovounesios
2021-05-09  9:52         ` Lars Ingebrigtsen
2021-05-09 10:03           ` Basil L. Contovounesios [this message]
2021-05-09 10:09             ` Lars Ingebrigtsen
2021-05-09 11:02               ` Basil L. Contovounesios
2021-05-09 10:35         ` Eli Zaretskii
2021-05-09 10:59           ` Basil L. Contovounesios
2021-05-09 11:49             ` Eli Zaretskii
2021-05-09 13:57               ` Basil L. Contovounesios
2021-05-09  7:30 ` Andreas Schwab
2021-05-11 20:56 ` bug#48298: Евгений Михайлов
2021-05-11 21:37   ` bug#48298: Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0o8441c.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=48298@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=lewwadoo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.