From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map Date: Mon, 19 Jul 2021 18:37:46 +0300 Organization: LINKOV.NET Message-ID: <87k0lml3wt.fsf@mail.linkov.net> References: <89178870.2006793.1626665845848@ichabod.co-bxl> <87eebupi5k.fsf@gnus.org> <343742107.2068902.1626706305280@ichabod.co-bxl> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2986"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 49632@debbugs.gnu.org To: Brian Leung Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 19 17:48:04 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5VUr-0000T0-2L for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jul 2021 17:47:57 +0200 Original-Received: from localhost ([::1]:48834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5VUp-0002jL-Uh for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jul 2021 11:47:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5VS4-00089F-L6 for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 11:45:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48420) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5VS2-00027R-Oc for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 11:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5VS2-0005cf-Nl for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 11:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jul 2021 15:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49632-submit@debbugs.gnu.org id=B49632.162670944821445 (code B ref 49632); Mon, 19 Jul 2021 15:45:02 +0000 Original-Received: (at 49632) by debbugs.gnu.org; 19 Jul 2021 15:44:08 +0000 Original-Received: from localhost ([127.0.0.1]:59961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5VRA-0005Zo-LB for submit@debbugs.gnu.org; Mon, 19 Jul 2021 11:44:08 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:60569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5VR9-0005YS-HJ for 49632@debbugs.gnu.org; Mon, 19 Jul 2021 11:44:08 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 0E5AC1BF204; Mon, 19 Jul 2021 15:43:59 +0000 (UTC) In-Reply-To: <343742107.2068902.1626706305280@ichabod.co-bxl> (Brian Leung's message of "Mon, 19 Jul 2021 16:51:45 +0200 (CEST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210273 Archived-At: >> But I don't quite understand why gud-repeat-map is populated in the >> normal way -- i.e., in `gud-repeat-map' so that users can >> redefine/override entries as usual. > > I think it is presently done this way because things like M-x gdb, M-x pdb, > etc. all use their own debugger commands, so we need to re-bind exactly the > right ones each time. For example, in M-x perldb, gud-finish, gud-up, and > gud-down are all commented out even though gdb clearly supports > those functions. Exactly. But this means that you need to populate a new separate map 'gdb-repeat-map' specific to 'gdb' commands. Also I noticed that the current name of 'gud-repeat-map' is wrong. It should be renamed to 'gud-gdb-repeat-map'. So other debuggers could populate own repeat-maps named e.g. 'sdb-repeat-map', 'jdb-repeat-map', 'perldb-repeat-map', etc.