From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuchen Pei Newsgroups: gmane.emacs.bugs Subject: bug#50195: [PATCH] Adding diary-offset, a diary-sexp offsetting another diary-sexp. Date: Thu, 26 Aug 2021 16:52:23 +1000 Message-ID: <87k0k8bsuw.fsf@ypei.me> References: <87fsuychjr.fsf@ypei.me> <83mtp5vizs.fsf@gnu.org> <875yvtk9ud.fsf@gnus.org> <83fsuxvhih.fsf@gnu.org> <878s0p4kir.fsf@web.de> <835yvtv778.fsf@gnu.org> <87v93t3355.fsf@web.de> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40782"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.13; emacs 27.2 Cc: larsi@gnus.org, 50195@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 26 08:53:26 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJ9GP-000AOd-Qp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 08:53:26 +0200 Original-Received: from localhost ([::1]:50586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJ9GN-0007Uo-Vt for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 02:53:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJ9G2-0007Tm-Rb for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 02:53:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36690) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJ9G1-0007Rf-Nz for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 02:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJ9G1-0000jz-MS for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 02:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuchen Pei Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Aug 2021 06:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50195 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50195-submit@debbugs.gnu.org id=B50195.16299607562811 (code B ref 50195); Thu, 26 Aug 2021 06:53:01 +0000 Original-Received: (at 50195) by debbugs.gnu.org; 26 Aug 2021 06:52:36 +0000 Original-Received: from localhost ([127.0.0.1]:48236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJ9Fc-0000jH-3p for submit@debbugs.gnu.org; Thu, 26 Aug 2021 02:52:36 -0400 Original-Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:58829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJ9Fa-0000j5-IX for 50195@debbugs.gnu.org; Thu, 26 Aug 2021 02:52:35 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id CA9F03200915; Thu, 26 Aug 2021 02:52:28 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 26 Aug 2021 02:52:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ypei.me; h= references:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; s=fm2; bh=4OmpQ8V8QamgOP6JVdtvsVgv3l TFRJtkjexK/cmEaio=; b=Hazw6VAEBDD1FlOlpgg+n0Q9PriFjpSgx1iHZ/fopx CKNO3TjfTeoLzZhgop4Ud7lxLHBHuZo9yHT6H4jMvKoBztsNCqiFKZyBNQ1alxTa 4n10o7q8cl2/cFnKUHVBdHLHLI8+MUbuQXDCzes8iIMW3cgafGp0Nh5zhfKbCKIM dEWM+p//orfv799jNv5YgnqLAiD8EVSSftBRvwHSd6VNyTPQ/UMPE+BHd0XYthpc 1qZJFjty4V0JhsrTUuU+VTG/MaXmay1RhpWd91AjSTJ4P3DV/QvIszvFrwEEjdAz 84kReo7XGxbMbwP+KB8rRkvK3r8GC/4tCwXdISiXBaGw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=4OmpQ8 V8QamgOP6JVdtvsVgv3lTFRJtkjexK/cmEaio=; b=p3bOnyzJbmoHhgXOsy9t6C uirKGyz6yhG7FWlcv3AkBd/pQOj8309IiXXQvPAZ0/bD0s6TjCSnvckLaQlvE+QN hEyMeohUV3amKhZZHmZKzSF3KdM09C1tHU5NbImlqBPKsT8UqKtnlJ0prgJgTXtI PvRJqpiSx+hF1yRJgUBnJJoVFqgRHQWoOBdJ1DHU9SGoCTgGnspfoDhdRmtXSGVW h8Y8KUG2uJhoWh2M6clwaXZt13q8zkFyiOGTtRnnQEcyke2N2KUCMJH8TBTqhWsL Y1t2/7J7lAoOGOlFA+lmRnwyaS3KTxzxkzLZlk2M2yrq8Ikiill1aHbO3Fpfq2Lg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddutddguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvffujgffkfggtgesghdtreertderjeenucfhrhhomhepjghutghh vghnucfrvghiuceohhhiseihphgvihdrmhgvqeenucggtffrrghtthgvrhhnpefggffhie eiuddtudejffdvkefgudellefhteefleffffejgfelleehvdekteejjeenucffohhmrghi nhephihpvghirdhmvgenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehhiheshihpvghirdhmvg X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 Aug 2021 02:52:25 -0400 (EDT) In-reply-to: <87v93t3355.fsf@web.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212691 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Michael Heerdegen writes: > Eli Zaretskii writes: > >> > That would not work, you would still get warnings about free=20 >> > variables. >> >> I don't understand. This code did compile under=20 >> dynamic-binding, so >> what warnings did you have in mind? > > You can just try, they look like > > | In diary-list-entries-1: > | diary-lib.el:731:17: Warning: reference to free variable=20 > =E2=80=98number=E2=80=99 > | diary-lib.el:734:48: Warning: reference to free variable=20 > =E2=80=98list-only=E2=80=99 > > I just removed lexical-binding from the header and commented the > `with-no-warnings' call in `diary-list-entries-1'. Which command did you use to compile? I compiled with just `make`=20 and there was no warning. > >> > This case is a bit special and not directly related to=20 >> > lexical-binding >> > because these variables are just not declared with `defvar'=20 >> > (and I think >> > we don't want to introduce global variables like `date'). >> >> You are saying this always emitted warnings? > > AFAIR there have been problems with these variables and warnings=20 > about > them for a long time, and different measures to handle them. I=20 > think > (I'm not sure) we had (defvar date) in the file in the past. If=20 > you > want to have any useful information you must ask Stefan, he was=20 > the one > that worked on that. > > Michael. =2D-=20 Best, Yuchen PGP Key: 47F9 D050 1E11 8879 9040 4941 2126 7E93 EF86 DFD0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIEEARYIACkWIQRH+dBQHhGIeZBASUEhJn6T74bf0AUCYSc6JwscaGlAeXBlaS5t ZQAKCRAhJn6T74bf0NTCAP9A4sl6nyLSzXDSBcb/b2IfSk0pRMNAon8CMHaBE8bR fQD/RdPNm+Ceenul5WKiNk6JcMRNW1w+kdJpruKV4X9kMwc= =K8k6 -----END PGP SIGNATURE----- --=-=-=--