From: Yuchen Pei <hi@ypei.me>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: larsi@gnus.org, 50195@debbugs.gnu.org
Subject: bug#50195: [PATCH] Adding diary-offset, a diary-sexp offsetting another diary-sexp.
Date: Thu, 26 Aug 2021 16:52:23 +1000 [thread overview]
Message-ID: <87k0k8bsuw.fsf@ypei.me> (raw)
In-Reply-To: <87v93t3355.fsf@web.de>
[-- Attachment #1: Type: text/plain, Size: 1548 bytes --]
Michael Heerdegen <michael_heerdegen@web.de> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> > That would not work, you would still get warnings about free
>> > variables.
>>
>> I don't understand. This code did compile under
>> dynamic-binding, so
>> what warnings did you have in mind?
>
> You can just try, they look like
>
> | In diary-list-entries-1:
> | diary-lib.el:731:17: Warning: reference to free variable
> ‘number’
> | diary-lib.el:734:48: Warning: reference to free variable
> ‘list-only’
>
> I just removed lexical-binding from the header and commented the
> `with-no-warnings' call in `diary-list-entries-1'.
Which command did you use to compile? I compiled with just `make`
and there was no warning.
>
>> > This case is a bit special and not directly related to
>> > lexical-binding
>> > because these variables are just not declared with `defvar'
>> > (and I think
>> > we don't want to introduce global variables like `date').
>>
>> You are saying this always emitted warnings?
>
> AFAIR there have been problems with these variables and warnings
> about
> them for a long time, and different measures to handle them. I
> think
> (I'm not sure) we had (defvar date) in the file in the past. If
> you
> want to have any useful information you must ask Stefan, he was
> the one
> that worked on that.
>
> Michael.
--
Best,
Yuchen
PGP Key: 47F9 D050 1E11 8879 9040 4941 2126 7E93 EF86 DFD0
<https://ypei.me/assets/ypei-pubkey.txt>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 243 bytes --]
next prev parent reply other threads:[~2021-08-26 6:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 3:46 bug#50195: [PATCH] Adding diary-offset, a diary-sexp offsetting another diary-sexp Yuchen Pei
2021-08-25 11:31 ` Lars Ingebrigtsen
2021-08-25 11:52 ` Eli Zaretskii
2021-08-25 12:06 ` Lars Ingebrigtsen
2021-08-25 12:24 ` Eli Zaretskii
2021-08-25 12:38 ` Lars Ingebrigtsen
2021-08-25 15:22 ` Michael Heerdegen
2021-08-25 15:32 ` Michael Heerdegen
2021-08-25 16:07 ` Eli Zaretskii
2021-08-25 16:22 ` Michael Heerdegen
2021-08-26 6:52 ` Yuchen Pei [this message]
2021-08-26 9:26 ` Michael Heerdegen
2021-08-26 6:49 ` bug#50195: [PATCH] Adding diary-offset to diary-lib.el Yuchen Pei
2021-08-26 6:54 ` Yuchen Pei
2021-08-27 13:16 ` Yuchen Pei
2021-09-03 22:40 ` Yuchen Pei
2021-09-04 6:15 ` Eli Zaretskii
2021-09-04 6:29 ` Lars Ingebrigtsen
2021-09-04 7:21 ` Yuchen Pei
2021-08-26 10:26 ` bug#50195: [PATCH] Adding diary-offset, a diary-sexp offsetting another diary-sexp Michael Heerdegen
2021-08-27 13:11 ` Yuchen Pei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0k8bsuw.fsf@ypei.me \
--to=hi@ypei.me \
--cc=50195@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.