From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: help-gnu-emacs@gnu.org
Subject: Re: script-representative-chars vs incomplete fonts
Date: Mon, 13 Sep 2021 00:21:30 +0200 [thread overview]
Message-ID: <87k0jlwi39.fsf@gmail.com> (raw)
In-Reply-To: <8335q9g0r5.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Sep 2021 20:30:22 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> I think it is easier to request both upper-case and lower-case
> letters; since the lower-case letters are at fixed offsets from their
> upper-case variants, we can compute the codepoints without changing
> the original database.
Noted.
>> Not sure it makes sense as-is though, since it yields a vector; judging
>> by script-representative-chars's docstring (and a cursory glance at
>> ftfont_list and font_match_p), a list would be more appropriate, to make
>> all codepoints mandatory?
>
> Why do you say that a list would be more appropriate? The doc string
> of script-representative-chars says:
>
> CHARS is a list or a vector of characters.
>
> So both lists and vectors are possible and supported.
The docstring also says this:
If it is a list, all characters in the list are necessary for
supporting SCRIPT.
If it is a vector, one of the characters in the vector is necessary.
That led me to think that we'd want a list, but now that I've looked at
ftfont.c and font.c more closely, I get the impression that this
distinction only applies to the verification step in font_match_p?
Hence it would indeed not matter whether we used a vector or a list for
the purposes of querying fontconfig.
(I hope I'm not misreading the code; apologies if so. I'm still not
entirely sure I understand why ftfont_spec_pattern seems to only handle
the list case while ftfont_list only handles the vector case, but I'm
sure I'll figure it out eventually after some more scowling)
Again, thanks for your advice.
next prev parent reply other threads:[~2021-09-12 22:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 22:09 script-representative-chars vs incomplete fonts Kévin Le Gouguec
2021-09-12 5:54 ` Eli Zaretskii
2021-09-12 17:08 ` Kévin Le Gouguec
2021-09-12 17:30 ` Eli Zaretskii
2021-09-12 22:21 ` Kévin Le Gouguec [this message]
2021-09-13 17:09 ` Eli Zaretskii
2021-09-13 22:46 ` Kévin Le Gouguec
2021-09-14 11:25 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0jlwi39.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=eliz@gnu.org \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.