From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Amin Bandali Newsgroups: gmane.emacs.bugs Subject: bug#46777: 28.0.50; ERC: NickServ identification: Prompt for password after other sources, overall simplifications Date: Sun, 19 Sep 2021 11:26:20 -0400 Message-ID: <87k0jc4meb.fsf@gnu.org> References: <5495728.XOh7uYVVfo@ravel> <87ilz03d4t.fsf@gnus.org> <87a6kbn72z.fsf@gnu.org> <2703107.iZhWRnD58j@ravel> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11464"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, 46777@debbugs.gnu.org, jp@neverwas.me To: Olivier Certner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 19 17:27:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRyin-0002ny-25 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Sep 2021 17:27:13 +0200 Original-Received: from localhost ([::1]:34780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRyil-0005T5-8K for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Sep 2021 11:27:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRyid-0005RN-63 for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 11:27:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56248) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRyic-0002Nj-Af for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 11:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRyic-0004xB-7j for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 11:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Amin Bandali Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Sep 2021 15:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46777 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46777-submit@debbugs.gnu.org id=B46777.163206519619006 (code B ref 46777); Sun, 19 Sep 2021 15:27:02 +0000 Original-Received: (at 46777) by debbugs.gnu.org; 19 Sep 2021 15:26:36 +0000 Original-Received: from localhost ([127.0.0.1]:39561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRyi8-0004wN-MZ for submit@debbugs.gnu.org; Sun, 19 Sep 2021 11:26:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRyi7-0004wB-GV for 46777@debbugs.gnu.org; Sun, 19 Sep 2021 11:26:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55558) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRyi1-0001tQ-FQ; Sun, 19 Sep 2021 11:26:25 -0400 Original-Received: from [2607:fea8:3fdf:f2d9:2c21:f874:901c:eb1c] (port=46954 helo=langa) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRyhx-00044s-SQ; Sun, 19 Sep 2021 11:26:25 -0400 In-Reply-To: <2703107.iZhWRnD58j@ravel> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214726 Archived-At: Hi Olivier, Olivier Certner writes: > Hi all, > > Sorry for not having much time to respond, and thanks for having handled the > compatibility concern through proposals 1 & 2, which I agree with. In > particular, it is best that PASSWORD remains the first parameter to `erc- > nickserv-identify', for compatibility but practical use also , since the nick > is normally already set when this function is called (non-interactively). > > The only thing I might have done differently is deleting `erc-nickserv-call- > identify-function' instead of obsoleting it since, contrary to `erc-nickserv- > identify', I don't think people would use it directly (the name sounds too > much "internal"; I may be wrong on its actual use, though). But your approach > is the most prudent one. No worries, and thanks. Yeah we probably could have indeed deleted `erc-nickserv-call-identify-function', but decided to play it safe(r) and keep it for now. :) > I'll try to hang around in #erc and respond to your mails a bit more quickly, > at least for matters that do not take much time. > > Thanks, > Olivier Thanks! -amin