From: Philip Kaludercic <philipk@posteo.net>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: 50679@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#50679: 28.0.50; outline-minor-mode-cycle should be able to only cycle at the begining of a line
Date: Tue, 21 Sep 2021 11:27:18 +0000 [thread overview]
Message-ID: <87k0jatbhl.fsf@posteo.net> (raw)
In-Reply-To: <87mto73xh5.fsf@gmail.com> (Augusto Stoffel's message of "Mon, 20 Sep 2021 20:36:54 +0200")
Augusto Stoffel <arstoffel@gmail.com> writes:
> On Mon, 20 Sep 2021 at 15:35, Philip Kaludercic <philipk@posteo.net> wrote:
>
>> Juri Linkov <juri@linkov.net> writes:
>>
>>>>> I didn't necessarily propose anything, it might only be able to solve
>>>>> this using a option like
>>>>>
>>>>> (defcustom outline-minor-mode-cycle-predicate ...)
>>>>>
>>>>> as to allow for users to configure cycling as they see fit. Of course if
>>>>> some consistent behaviour could be found that respects other options and
>>>>> modes, then something automatic could also be used.
>>>>
>>>> Probably offloading the decision to the users with a customizable option
>>>> is all what we can do here, indeed.
>>>
>>> Maybe something like:
>>>
>>> (defvar outline-mode-cycle-map
>>> (let ((map (make-sparse-keymap)))
>>> (let ((tab-binding `(menu-item
>>> "" outline-cycle
>>> ;; Only takes effect if point is on a heading.
>>> :filter ,(lambda (cmd)
>>> - (when (outline-on-heading-p) cmd)))))
>>> + (when (and (outline-on-heading-p)
>>> + (or (not (functionp outline-mode-cycle-filter))
>>> + (funcall outline-mode-cycle-filter)))
>>> + cmd)))))
>>> (define-key map (kbd "TAB") tab-binding)
>>> (define-key map (kbd "<backtab>") #'outline-cycle-buffer))
>>> map)
>>>
>>> Then you can customize it to 'bolp'.
>>
>> I just tried it out, and it looks good. The only thing I wonder is if
>> this should apply to both outline-minor-mode and outline-mode?
>
> FWIW, I think it would be nice to provide a simple way to define other
> “speed keys” in `outline-minor-mode [1], or even provide some
> pre-configured ones [2].
>
> Looking at the code, it seems that adding bindings to
> `outline-mode-cycle-map` would achieve precisely that, but the name
> of the keymap doesn't reflect that.
I would appreciate something like this too, but you are right that it
sounds like a separate functionality. Compared to
outline-mode-cycle-map, this would most certainly have to operate on the
beginning of a line, otherwise apparently random keys would suddenly
throw the user around without them expecting it.
> [1]: Cf. https://orgmode.org/manual/Speed-Keys.html
>
> [2]: I personally use these speed keys in outline-minor-mode, which are
> probably very similar to those from Org mode:
>
> "<tab>" 'outline-cycle
> "<backtab>" 'outline-cycle-buffer
> "f" 'outline-forward-same-level
> "b" 'outline-backward-same-level
> "n" 'outline-next-visible-heading
> "p" 'outline-previous-visible-heading
> "u" 'outline-up-heading
> "F" 'outline-move-subtree-down
> "B" 'outline-move-subtree-up
> "@" 'outline-mark-subtree
--
Philip Kaludercic
next prev parent reply other threads:[~2021-09-21 11:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-19 16:24 bug#50679: 28.0.50; outline-minor-mode-cycle should be able to only cycle at the begining of a line Philip Kaludercic
2021-09-19 16:53 ` Juri Linkov
2021-09-19 20:40 ` Philip Kaludercic
2021-09-20 7:02 ` Juri Linkov
2021-09-20 15:25 ` Juri Linkov
2021-09-20 15:35 ` Philip Kaludercic
2021-09-20 18:36 ` Augusto Stoffel
2021-09-21 11:27 ` Philip Kaludercic [this message]
2021-09-21 11:44 ` Augusto Stoffel
2021-09-21 11:58 ` Philip Kaludercic
2021-09-21 19:02 ` Augusto Stoffel
2021-09-21 17:58 ` Juri Linkov
2021-09-21 18:50 ` Augusto Stoffel
2021-09-22 16:09 ` Juri Linkov
2021-09-22 16:30 ` Augusto Stoffel
2021-09-23 16:15 ` Juri Linkov
2021-09-21 17:53 ` Juri Linkov
2021-09-23 16:17 ` Juri Linkov
2021-09-26 13:59 ` Philip Kaludercic
2021-09-27 15:35 ` Juri Linkov
2021-09-27 16:16 ` Augusto Stoffel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0jatbhl.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=50679@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.