From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Path & Demo: Source View in Help Buffers Date: Wed, 22 Sep 2021 13:32:57 +0200 Message-ID: <87k0j8j0v3.fsf@gnu.org> References: <87o88kj2oz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11374"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.6; emacs 28.0.50 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 22 13:42:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mT0dg-0002jB-4I for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Sep 2021 13:42:12 +0200 Original-Received: from localhost ([::1]:34300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT0de-0004JC-4x for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Sep 2021 07:42:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT0aq-0003Eo-PM for emacs-devel@gnu.org; Wed, 22 Sep 2021 07:39:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60084) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT0aq-0004wX-IS for emacs-devel@gnu.org; Wed, 22 Sep 2021 07:39:16 -0400 Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:57989) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT0aq-0004z2-Ek for emacs-devel@gnu.org; Wed, 22 Sep 2021 07:39:16 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id 3E72827C0054 for ; Wed, 22 Sep 2021 07:39:14 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 22 Sep 2021 07:39:14 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeijedggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpehffgfhvffuffgjkfggtgesthdtre dttdertdenucfhrhhomhepvfgrshhsihhlohcujfhorhhnuceothhsughhsehgnhhurdho rhhgqeenucggtffrrghtthgvrhhnpeevveeikeetkeeviefgfeffiedvteeguddvffeuue duveegtddthedvhfeuveffhfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhorhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhith ihqdekieejfeekjeekgedqieefhedvleekqdhtshguhheppehgnhhurdhorhhgsehfrghs thhmrghilhdrfhhm X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 22 Sep 2021 07:39:13 -0400 (EDT) In-reply-to: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275313 Archived-At: Arthur Miller writes: >> Out of curiosity, why do you have fboundp-checks for font-lock-ensure >> in the code? That's always true, isn't it? > > I don't know. Since font-lock has all its stuff abstracted into buffer > local function variables, I am not sure if I can count it is not nil? But it's no buffer-local variable, it's a function. If you have emacs 25.1 upwards, you have `font-lock-ensure'. > If I can I would gladly remove the check. I appreciate advice, I am > not so familiar with all the details of everything. I think that's a common check for 3rd-party packages which want to keep supporting emacs 24. But since you are hacking emacs core, there's no need for that unless the function/variable is only defined if some configure option is given or some lib is available. But none of the latter applies to font-lock.el. Bye, Tassilo