From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51700: 29.0.50; [PATCH]: Fix earlier changes in xwidget.el Date: Tue, 09 Nov 2021 13:36:49 +0800 Message-ID: <87k0hhnb4e.fsf@yahoo.com> References: <87k0hhnb4e.fsf.ref@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1629"; mail-complaints-to="usenet@ciao.gmane.io" To: 51700@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 09 06:38:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkJpl-0000Fj-0p for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Nov 2021 06:38:13 +0100 Original-Received: from localhost ([::1]:33584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkJpj-0008Du-6k for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Nov 2021 00:38:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkJpb-0008Di-0E for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 00:38:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48818) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mkJpa-0003Pr-No for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 00:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mkJpa-00056y-Lh for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 00:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Nov 2021 05:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51700 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163643622819577 (code B ref -1); Tue, 09 Nov 2021 05:38:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Nov 2021 05:37:08 +0000 Original-Received: from localhost ([127.0.0.1]:60364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkJoi-00055h-CU for submit@debbugs.gnu.org; Tue, 09 Nov 2021 00:37:08 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:35222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkJoe-00055Y-Kq for submit@debbugs.gnu.org; Tue, 09 Nov 2021 00:37:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkJoe-0008Al-Bb for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 00:37:04 -0500 Original-Received: from sonic313-10.consmr.mail.ne1.yahoo.com ([66.163.185.33]:36811) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mkJob-0003Ff-S0 for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 00:37:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636436219; bh=0rOEVr3RizR2ypn7ewBM8M21RPLwEU3UHd31/fi0LKc=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=clo35r7fT6db5xTTRmcFOpWlIgCQ5QuTvNM3LXK91aIw7NFqY2g/Oyn6LJG2jmLpPOga4+US9NxxZzhUeD3e7dMPsQj25Gj727SOo2srtQirnoN/KDdvQshA5aZVTza+LVxMlfKzW+SDFMGoWb+MApLm7+EO2F4OIeOWplX/Y03/IbvZpVcC1uqn6fFurHHneaFOUfYOVG9bcHZuToNCLjFgdA0FAWsuxBPQty45qwkQDKN5tzFeuskdWi83W8Y6h97vurTtgw/afM4OcAWteFNh9XxDVqvCt/im/wcrRk80KbdRCOHYGi7ycntnKTw8n1Avi1Hx/iFq6ve7NVvt4A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636436219; bh=t6ysHT0H3tJxOrEojbAT3C0WeuLJOzk+KEeka++wWRA=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=oJb0J5yrd0Jwt4AvpiqmJ9PRfRXpndIZkDREfbICo9IuhlhnPHTs6Tirk6i9YQUIGYy9pryV8BG83rB0nclqEg+1MdKzYLOiEGpvxf7yloWSF3Hdh3X2rRgPAgiBlPTdPLw2XvbAPKyq0gdDcp3eqo0sXgJXRc1FeSUYRDOJqOyiWFdhNV+IZeZtEv4QONC6y8vikIJvvxLvlw+IVVfn8BpvunQrnCYUjnS2YJA0h8XjFxgTC4oNbqSIGFZxxYwFyWJlsyu7rB3+FvWA2e25vj7F1dbCFKa3l3y6yAEhPL79/JPX/ZqHJEQQUDs77VihU41auOESSodjA7O3KhPJow== X-YMail-OSG: AjFvxn8VM1lwJ7FmSjln2Z5bXoAZ29FFim8vMEpgNGx1vLL2vu7xwgC4ALkcfod oCkj.OKOYd8ATJTc6ZpAnZ6RtptnMwcvG1B1NZKsY.GHiBwoWmxjrfWkzJCTdD9ENIEXPWyEpHY3 8kLsUsVVvFF81sg.pj812sItsYaLfdJcaBTVJERq0Coq04LorN7_xoKBf4lqh1RYCw02iAfwnZLQ 2JAWpWE9WP349.dMuCM5qDNdFXSvlGGYkGo5bHYz_LUsxgmC9jUmXmrAhPZ8XXtK1_2u.RSkyOsr h.0TS3.dpqKjsXvsCo0PkzEwftSPm.TS8XTJXbIwM3YXZEDRzU18p9JstHvKFlGeoqfibrBeOB.Q iI.ycGh.DUXcY5d9TGXUnprDOVoJF74cYMHK.QctHN7CSTkmhxnw8stnnLQNZCyypVNsIcIZCSHi ENxg9ysn24Oq46VTfer32dd2ewKRjT2dsHBx1wB2C6tXPVOl8QgSMovjLWa9lzLSmZwS36TxxUyS lxwaoYw3qTxju9mVPd2DvAlVjbguxpK2B9fHFpVzhF6iNh6hFV3kXozjxFXsdjJnoY8z2F.oXqq6 0qCcDk9eG5hxILLRZQNIILMPcoF9.Ewl4QfwSBVwSaux.VdeHVvw87XRO8NxEIbk.H0mHVBqnALw CdtlmccAkpE6gROHgG6sSPpOUMllpX2jFSuUiDoB96RPZ6vx7U50U7wd7o.pmm0bM3HGJKSSMU_Q teQ7qxovRobwwzeR4XWP.r6XWUDAR5GOKKIdressF8ACwrmHzdvCmX.cpFp_V120TbRzNjGh7ufc Q59on5olns.NriVhk829aDiWCKXEJGTPqvHuM2sHCa X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Tue, 9 Nov 2021 05:36:59 +0000 Original-Received: by kubenode515.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 68d33c36d1bf0124627437cb31f4b96e; Tue, 09 Nov 2021 05:36:53 +0000 (UTC) X-Mailer: WebService/1.1.19266 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.185.33; envelope-from=luangruo@yahoo.com; helo=sonic313-10.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219404 Archived-At: --=-=-= Content-Type: text/plain The test suite I was working on have already proved their utility, nice. Unfortunately I haven't been able to get some of the tests to work reliably, and as such don't wish to publish them right now. Please bear with me, thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Make-xwidget-tests-pass-again.patch >From 40ea895cbf15849757abc445791b891112064eda Mon Sep 17 00:00:00 2001 From: Po Lu Date: Tue, 9 Nov 2021 13:33:49 +0800 Subject: [PATCH] Make xwidget-tests pass again * lisp/xwidget.el (xwidget-webkit-buffer-name-prefix): Remove extra space. (xwidget-webkit-callback): Add trailing "*" to buffer name. (xwidget-webkit-new-session, xwidget-webkit-import-widget): Always use existing buffer name. --- lisp/xwidget.el | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/lisp/xwidget.el b/lisp/xwidget.el index 91d02e8fce..c2b3826733 100644 --- a/lisp/xwidget.el +++ b/lisp/xwidget.el @@ -95,7 +95,7 @@ xwidget-webkit :group 'web :prefix "xwidget-webkit-") -(defcustom xwidget-webkit-buffer-name-prefix "* xwidget-webkit: " +(defcustom xwidget-webkit-buffer-name-prefix "*xwidget-webkit: " "Buffer name prefix used by `xwidget-webkit' buffers." :type 'string :version "29.1") @@ -370,7 +370,7 @@ xwidget-webkit-callback ;; selected window can be the mini-buffer window ;; unwantedly. (rename-buffer (concat xwidget-webkit-buffer-name-prefix - title) + title "*") t))))) ((eq xwidget-event-type 'decide-policy) (let ((strarg (nth 3 last-input-event))) @@ -705,8 +705,7 @@ xwidget-webkit-new-session ;; will be renamed by `xwidget-webkit-callback' in the ;; future. This approach can limit flicker of buffer-name in ;; mode-line. - (concat xwidget-webkit-buffer-name-prefix - (generate-new-buffer-name (buffer-name)))) + (generate-new-buffer-name (buffer-name))) (callback (or callback #'xwidget-webkit-callback)) (current-session (xwidget-webkit-current-session)) xw) @@ -735,11 +734,7 @@ xwidget-webkit-import-widget ;; will be renamed by `xwidget-webkit-callback' in the ;; future. This approach can limit flicker of buffer-name in ;; mode-line. - (if (string-prefix-p xwidget-webkit-buffer-name-prefix - (buffer-name)) - (generate-new-buffer-name (buffer-name)) - (concat xwidget-webkit-buffer-name-prefix - (generate-new-buffer-name (buffer-name))))) + (generate-new-buffer-name (buffer-name))) (callback #'xwidget-webkit-callback) (buffer (get-buffer-create bufname))) (with-current-buffer buffer -- 2.31.1 --=-=-=--