From: Timothy <tecosaur@gmail.com>
To: "Guillaume Buisson (gbuisson)" <gbuisson@cisco.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix ob-plantuml over TRAMP
Date: Thu, 02 Dec 2021 17:43:25 +0800 [thread overview]
Message-ID: <87k0gnpchb.fsf@gmail.com> (raw)
In-Reply-To: <0158722C-D64B-4CB7-A25A-8F6FD7D9A2A9@cisco.com>
[-- Attachment #1: Type: text/plain, Size: 904 bytes --]
Hi Guillaume,
Thanks for picking this up and submitting a patch.
Have you considered using `tramp-handle-file-exists-p'? I’m not overly familiar
with tramp or this sort of issue, but it looks like it could be exactly what we want.
> My Emacs Workflow involves connecting to a dev server over SSH so I can use my
> machines as thin clients and avoid synchronizing files, for that I do pretty
> much everything over TRAMP as I don’t want to lose the benefits of GUI Emacs.
> While everything mostly works impressively fine, I noticed writing my
> specifications that ob-plantuml fails to generate diagrams.
>
> It seems to me that there is a redundant check which uses `file-exists-p` even
> if using TRAMP, the plantuml jar is located on the remote server, so it fails
> with an error even though the command to actually render the diagrams works
> fine.
All the best,
Timothy
next prev parent reply other threads:[~2021-12-02 9:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 16:11 [PATCH] Fix ob-plantuml over TRAMP Guillaume Buisson (gbuisson)
2021-12-02 9:43 ` Timothy [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-24 17:29 guillaume
2021-11-25 12:40 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0gnpchb.fsf@gmail.com \
--to=tecosaur@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=gbuisson@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.