From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Pieter van Prooijen <pieter.van.prooijen@teloden.nl>
Cc: Eli Zaretskii <eliz@gnu.org>, 54564@debbugs.gnu.org
Subject: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds
Date: Fri, 01 Apr 2022 10:00:10 +0800 [thread overview]
Message-ID: <87k0c9imvp.fsf@yahoo.com> (raw)
In-Reply-To: <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> (Pieter van Prooijen's message of "Thu, 31 Mar 2022 19:30:58 +0200")
Pieter van Prooijen <pieter.van.prooijen@teloden.nl> writes:
> Hi All,
>
> Thanks for the review, I've updated the commit message and other
> changes you mentioned in the attached patch (against
> c5af19cba5924de89a38e7a177c07f42fd3cd543)
>
> I've requested the form for the copyright assignment, but have not
> received it yet, will send it in as soon as it arrives.
>
> No progress yet on the problem with subpixel antialiasing, but it
> doesn't look like a fontconfig issue, as a non-pgtk build from the same
> source works correctly, will have to dig deeper to find out what is
> happening.
Thanks.
>> > + on the result. */
Hmm... Is there an actual non-breaking space character here, or is your
MUA munging the messages?
> + if (dpyinfo_valid (first_dpyinfo))
> + store_config_changed_event (Qfont_render,
> + XCAR (first_dpyinfo->name_list_element));
You got the indentation wrong here. The "s" in
"store_config_changed_event" should be two spaces behind where it is
now.
Otherwise, LGTM. Hopefully the copyright paperwork can be finished soon.
next prev parent reply other threads:[~2022-04-01 2:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 11:23 bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds Pieter van Prooijen
2022-03-26 1:16 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-26 6:01 ` Eli Zaretskii
2022-03-26 6:07 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-26 6:20 ` Eli Zaretskii
2022-03-26 6:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-26 7:45 ` Eli Zaretskii
2022-03-26 8:11 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-26 9:36 ` Eli Zaretskii
2022-03-26 15:48 ` Pieter van Prooijen
2022-03-27 0:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-30 8:01 ` Pieter van Prooijen
2022-03-30 8:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-31 17:30 ` Pieter van Prooijen
2022-04-01 2:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-04-07 19:24 ` Pieter van Prooijen
2022-04-07 23:38 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-08 18:44 ` Pieter van Prooijen
2022-04-09 0:35 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-13 11:38 ` Pieter van Prooijen
2022-05-13 11:55 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-13 11:57 ` Lars Ingebrigtsen
2022-05-13 12:12 ` Eli Zaretskii
2022-05-13 12:51 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0c9imvp.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=54564@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
--cc=pieter.van.prooijen@teloden.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.