From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master bbb92dde01 1/3: Add unit tests and documentation for Eshell pattern-based globs Date: Sun, 17 Apr 2022 21:51:41 +0200 Message-ID: <87k0bn5vzm.fsf@gnus.org> References: <165018069752.13409.7508805625490994436@vcs2.savannah.gnu.org> <20220417073140.7A60AC01684@vcs2.savannah.gnu.org> <875yn8ca52.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16831"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 17 21:53:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngAxp-0004FG-Gp for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Apr 2022 21:53:41 +0200 Original-Received: from localhost ([::1]:37934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngAxo-0007Es-FS for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Apr 2022 15:53:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngAwA-0006NY-Tk for emacs-devel@gnu.org; Sun, 17 Apr 2022 15:52:01 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:35926) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngAw9-0006ic-8M for emacs-devel@gnu.org; Sun, 17 Apr 2022 15:51:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WDVqGYYcIJIDOa9OK+/osPfU122HQ7OKGnaZ+34vA+0=; b=ikLCCJF6eQY29hybpS4stjXAIP Mangxfe0F22dQfwIx3Q0EgR6CN6+Xf6HUSIRBvudt6RyCMD35EyjvyzHbyDlq1cQDRK/HDO64vpAn +/iwNRuA778uahO2KlmJme5tfkaiVdjtwUFaO5IVWrfDjlbVezYfCb6UQMWT7RHLtzvw=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngAvw-0001Gk-M6; Sun, 17 Apr 2022 21:51:48 +0200 In-Reply-To: (Jim Porter's message of "Sun, 17 Apr 2022 12:44:35 -0700") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288572 Archived-At: Jim Porter writes: > Does the attached patch fix it? I think the issue was that > `eshell-partial-let-func' got the original function value too early, > so during macro-expansion, it would insert something like `# file-attributes>', which the parser didn't like. I've moved this bit > later and it works for me. Yup; thanks. Pushed to Emacs 29 now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no