From: Lars Ingebrigtsen <larsi@gnus.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master bbb92dde01 1/3: Add unit tests and documentation for Eshell pattern-based globs
Date: Sun, 17 Apr 2022 21:51:41 +0200 [thread overview]
Message-ID: <87k0bn5vzm.fsf@gnus.org> (raw)
In-Reply-To: <c90408d0-958c-cd3f-f148-45fbef9a19bc@gmail.com> (Jim Porter's message of "Sun, 17 Apr 2022 12:44:35 -0700")
Jim Porter <jporterbugs@gmail.com> writes:
> Does the attached patch fix it? I think the issue was that
> `eshell-partial-let-func' got the original function value too early,
> so during macro-expansion, it would insert something like `#<subr
> file-attributes>', which the parser didn't like. I've moved this bit
> later and it works for me.
Yup; thanks. Pushed to Emacs 29 now.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2022-04-17 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165018069752.13409.7508805625490994436@vcs2.savannah.gnu.org>
[not found] ` <20220417073140.7A60AC01684@vcs2.savannah.gnu.org>
2022-04-17 9:49 ` master bbb92dde01 1/3: Add unit tests and documentation for Eshell pattern-based globs Lars Ingebrigtsen
2022-04-17 19:44 ` Jim Porter
2022-04-17 19:51 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0bn5vzm.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.