From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Daniel Mendler <mail@daniel-mendler.de>,
Eli Zaretskii <eliz@gnu.org>,
55205@debbugs.gnu.org
Subject: bug#55205: 28.1.50; completion--replace illegally mutates completion candidates
Date: Tue, 03 May 2022 12:13:36 +0200 [thread overview]
Message-ID: <87k0b2zzxr.fsf@gnus.org> (raw)
In-Reply-To: <jwva6c0jg8s.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 02 May 2022 08:23:57 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> The strings used for completions are the "identity" of each completion.
> so if there are two distinct completions, they should have
> distinct strings. I don't see what's artificial about it.
The "are" there is doing a lot of work here. :-) In my use case, the
stringly representation is not the identity of the selection.
> Somehow the user (and the code) needs to be able to distinguish between
> the various identically named movies. You do that with a poster image
> and I'm suggesting that this poster image should be covering some
> "unique" identification information. I.e. something like:
>
> (concat movie-name (propertize movie-id 'display movie-poster))
And that is the artificiality of it. If you're on a web page listing
different items, and they have the same name, you don't see the web
designers putting made-up irrelevant characters into the link text --
they keep the identifying stuff hidden in the links.
> The rest of the discussion made me realize that maybe I misunderstood
> your question. Are you talking about the stripping that takes places
> *during completion* (e.g. when clicking in *Completions*) or are you
> talking about the stripping that takes place just before returning the
> value of `completing-read`? Some other?
I don't remember any more -- I only know that the text properties are
stripped at some point.
>> I.e., if we add an interface to allow completion to not strip text
>> properties, is that going to lead to bugs?
>
> What do you mean by "interface"? You mean a UI or an API?
> For an API it would probably lead to this API being virtually unusable
> for some UIs.
I was being vague, because I don't know how we'd specify "don't strip
the text properties". Probably like how we specify affixation functions
and all the rest.
But I still have no idea why we're stripping text properties in the
first place, so could you please explain that?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-05-03 10:13 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 8:27 bug#55205: 28.1.50; completion--replace illegally mutates completion candidates Daniel Mendler
2022-05-01 11:53 ` Lars Ingebrigtsen
2022-05-01 12:17 ` Eli Zaretskii
2022-05-01 20:11 ` Dmitry Gutov
2022-05-02 2:23 ` Eli Zaretskii
2022-05-02 9:46 ` Dmitry Gutov
2022-05-02 14:27 ` Eli Zaretskii
2022-05-02 21:06 ` Dmitry Gutov
2022-05-02 16:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-02 16:24 ` Eli Zaretskii
2022-05-02 16:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-02 16:38 ` Daniel Mendler
2022-05-02 16:47 ` Eli Zaretskii
2022-05-02 16:43 ` Eli Zaretskii
2022-05-02 16:48 ` Daniel Mendler
2022-05-02 16:53 ` Eli Zaretskii
2022-05-02 16:57 ` Daniel Mendler
2022-05-02 17:53 ` Eli Zaretskii
2022-05-02 18:35 ` Daniel Mendler
2022-05-02 21:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-01 12:40 ` Daniel Mendler
2022-05-01 12:49 ` Eli Zaretskii
2022-05-01 12:54 ` Daniel Mendler
2022-05-01 13:16 ` Eli Zaretskii
2022-05-01 13:19 ` Daniel Mendler
2022-05-01 13:21 ` Daniel Mendler
2022-05-01 12:50 ` Daniel Mendler
2022-05-01 17:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-01 17:26 ` Lars Ingebrigtsen
2022-05-01 17:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-01 17:48 ` Lars Ingebrigtsen
2022-05-01 18:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-01 18:27 ` Daniel Mendler
2022-05-01 18:39 ` Lars Ingebrigtsen
2022-05-01 19:01 ` Daniel Mendler
2022-05-01 19:07 ` Lars Ingebrigtsen
2022-05-01 20:52 ` Dmitry Gutov
2022-05-01 20:54 ` Lars Ingebrigtsen
2022-05-01 21:30 ` Dmitry Gutov
2022-05-01 21:43 ` Lars Ingebrigtsen
2022-05-02 6:31 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-02 8:11 ` Lars Ingebrigtsen
2022-05-02 9:00 ` Daniel Mendler
2022-05-02 12:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-03 10:13 ` Lars Ingebrigtsen [this message]
2022-05-03 12:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-04 7:48 ` Lars Ingebrigtsen
2022-05-04 8:24 ` Daniel Mendler
2022-05-04 8:51 ` Daniel Mendler
2022-05-02 8:49 ` Daniel Mendler
2022-05-02 9:04 ` Lars Ingebrigtsen
2022-05-02 9:57 ` Daniel Mendler
2022-05-02 10:07 ` Lars Ingebrigtsen
2022-05-02 10:17 ` Daniel Mendler
2022-05-01 17:39 ` Eli Zaretskii
2022-05-01 18:06 ` Daniel Mendler
2022-05-02 0:34 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0b2zzxr.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=55205@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.