all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: "András Simonyi" <andras.simonyi@gmail.com>
Cc: emacs-orgmode list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] oc-csl: Add support for nocite citations
Date: Sat, 02 Jul 2022 12:38:57 +0800	[thread overview]
Message-ID: <87k08wi0wu.fsf@localhost> (raw)
In-Reply-To: <CAOWRwxCwgO_S=jUMhBJHXiAJ=ie1kSsjS11Xd3-Fsf9etY=fgA@mail.gmail.com>

András Simonyi <andras.simonyi@gmail.com> writes:

> the attached patch adds support for nocite citations in the csl
> org-cite export processor, including support for using the special key
> "*" to include all entries in the bibliography.

Thanks!
By "*", do you mean something like [cite/n:@*]?
If so, will it be correctly fontified as an existing citation?

> +*** Support for nocite citations in the csl export processor
>  
> +The csl citation export processor now supports `nocite' style
> +citations that add items to the printed bibliography without visible
> +references in the text. Using the key `*' in a nocite citation
> +includes all available items in the printed bibliography.

It would help to provide an example how to use "*" key.
Also, I'd prefer if you follow doc/Documentation_Standards.org. Please
use Org markup instead of `...' quotes.

> +(defun org-cite-csl--nocite-p (citation info)
> +  "Non-nil when CITATION object's style is nocite.
> +INFO is the export state, as a property list."
> +  (when-let ((style (car (org-cite-citation-style citation info))))
> +    (or (string= style "nocite") (string= style "n"))))

Why not simply
(member (car (org-cite-citation-style citation info)) '("nocite" "n"))
?

Best,
Ihor


  reply	other threads:[~2022-07-02  4:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-01  9:30 [PATCH] oc-csl: Add support for nocite citations András Simonyi
2022-07-02  4:38 ` Ihor Radchenko [this message]
2022-07-02  8:32   ` András Simonyi
2022-07-03 11:58     ` Ihor Radchenko
2022-07-03 12:26       ` Bruce D'Arcus
2022-07-03 12:35         ` Ihor Radchenko
2022-07-03 12:38           ` Bruce D'Arcus
2022-07-03 12:53           ` John Kitchin
2022-07-03 13:10             ` [BUG] @* in [cite/nocite:@*] is a valid special LaTeX bibliography key, but it is highlighted using "error" face by oc.el (was: [PATCH] oc-csl: Add support for nocite citations) Ihor Radchenko
2022-07-04  6:53               ` András Simonyi
2022-07-04 12:28                 ` Ihor Radchenko
2022-07-04 12:57                   ` András Simonyi
2022-07-04 13:16                     ` Bruce D'Arcus
2022-07-04 11:54     ` [PATCH] oc-csl: Add support for nocite citations Ihor Radchenko
2022-07-05 19:17       ` Bruce D'Arcus
2022-07-05 19:28         ` Bruce D'Arcus
2022-07-05 19:37           ` Bruce D'Arcus
2022-07-07 10:46         ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k08wi0wu.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=andras.simonyi@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.